-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double IQN #503
Double IQN #503
Conversation
Out of 16 domains, Double 3-Step IQN vs. ChainerRL's IQN:
|
Double IQN wins on 4 domains |
Full fledged IQN Results
Double IQN wins on 12 domains! |
I think it is better to explicitly add |
chainerrl/agents/double_iqn.py
Outdated
|
||
|
||
class DoubleIQN(iqn.IQN): | ||
"""Double IQN - Use primary network for target computation.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think Use primary network for target computation
is a good description of the algorithm. Can you just say something like IQN with DoubleDQN-like target computation
in the first line and add a detailed explanation after a blank line (as suggested by the google style https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings)?
This PR adds Double IQN. This PR includes a new example script for IQN based agents (since it does not fall under "reproducibility". It includes a new Agent
DoubleIQN
, as well as a test.