Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValueError in SARSA with GPU #534

Merged
merged 5 commits into from
Aug 30, 2019
Merged

Conversation

muupan
Copy link
Member

@muupan muupan commented Aug 25, 2019

Merge #528 first.

Resolves #535

Please run gpu slow tests tests/agents_tests/test_sarsa.py to see if the issue is solved.

because pasing both cupy.array and int at the same time to cupy.array causes
an error.
@muupan muupan changed the title Fix an error in SARSA with Fix an error in SARSA with GPU Aug 25, 2019
@muupan muupan changed the title Fix an error in SARSA with GPU Fix ValueError in SARSA with GPU Aug 25, 2019
@muupan muupan changed the title Fix ValueError in SARSA with GPU [WIP] Fix ValueError in SARSA with GPU Aug 25, 2019
@muupan muupan changed the title [WIP] Fix ValueError in SARSA with GPU Fix ValueError in SARSA with GPU Aug 26, 2019
@muupan muupan added the bug label Aug 26, 2019
@muupan
Copy link
Member Author

muupan commented Aug 26, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 0b78e07:

Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muupan
Copy link
Member Author

muupan commented Aug 29, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 1938f7f:

@muupan
Copy link
Member Author

muupan commented Aug 29, 2019

/test

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit a3cf4b2:

@muupan muupan merged commit 49425d0 into chainer:master Aug 30, 2019
@muupan muupan deleted the fix-sarsa-gpu branch August 30, 2019 03:12
@muupan muupan added this to the v0.8 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SARSA raises an error with GPU: ValueError: Unsupported dtype object
3 participants