-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ValueError in SARSA with GPU #534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because pasing both cupy.array and int at the same time to cupy.array causes an error.
muupan
changed the title
Fix an error in SARSA with GPU
Fix ValueError in SARSA with GPU
Aug 25, 2019
muupan
changed the title
Fix ValueError in SARSA with GPU
[WIP] Fix ValueError in SARSA with GPU
Aug 25, 2019
muupan
changed the title
[WIP] Fix ValueError in SARSA with GPU
Fix ValueError in SARSA with GPU
Aug 26, 2019
/test |
Successfully created a job for commit 0b78e07: |
toslunar
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test |
Successfully created a job for commit 1938f7f: |
/test |
Successfully created a job for commit a3cf4b2: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #528 first.Resolves #535
Please run gpu slow tests tests/agents_tests/test_sarsa.py to see if the issue is solved.