-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run slow tests with flexCI #575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as zerograds is deprecated by Chainer
because pasing both cupy.array and int at the same time to cupy.array causes an error.
…d' into flexci-slow-tests
to allow Link.cleargrads
/test |
Successfully created a job for commit 695734a: |
prabhatnagarajan
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #499 by adding configs and changes to run slow tests with flexCI:
tests/agents_tests/test_agents.py
fasterLink.zerograds
Link.cleargrads
and modifycopy_grad
function accordingly.I confirmed that both
chainerrl.py3.cpu.slow
andchainerrl.py3.gpu.slow
succeed when started manually:After the PR is merged, I will configure the repository so that these are run by
/test
and required to succeed in order to merge PRs.