fix: duplicate logging #3939
Merged
fix: duplicate logging #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRO-810 Dot finalised logging duplicates log message
|
kylezs
commented
Sep 4, 2023
| ProxyAdded(ProxyAdded), | ||
| Transfer(Transfer), | ||
| TransactionFeePaid(TransactionFeePaid), | ||
| ProxyAdded { delegator: AccountId32, delegatee: AccountId32 }, |
There was a problem hiding this comment.
had to do this so the events could be Clone
Codecov Report
@@ Coverage Diff @@
## main #3939 +/- ##
=====================================
- Coverage 73% 73% -0%
=====================================
Files 367 367
Lines 56051 56047 -4
Branches 56051 56047 -4
=====================================
- Hits 40649 40635 -14
- Misses 13343 13349 +6
- Partials 2059 2063 +4
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlastairHolmes
approved these changes
Sep 5, 2023
dandanlen
pushed a commit
that referenced
this pull request
Sep 6, 2023
* fix: duplicate logging * chore: remove unnecessary clone
dandanlen
pushed a commit
that referenced
this pull request
Sep 6, 2023
* fix: duplicate logging * chore: remove unnecessary clone
syan095
added a commit
that referenced
this pull request
Sep 8, 2023
…on-integration * origin/main: fix: scale encoding skip phantom data (#3967) chore: make platform team code owner of CI settings.toml and localnet (#3957) fix: prefer finalize_signed_extrinsic in engine (#3956) fix: CanonicalAssetPair encoding issue (#3958) chore(bouncer): Update sdk to 0.0.40 (#3945) fix: tweak cli generate-keys output (#3943) chore: add `preinst` script unit tests 🧪 (#3942) Better LP/Broker API RPC Errors (#3931) fix: update substrate ref to use Kademlia fix (#3941) doc: update funding readme with redemption restrictions (#3914) feat: PRO-474 broadcast safe mode (#3902) feat: more forgiving dot address parsing (#3938) fix: duplicate logging (#3939) feat: new lp interface (#3886) # Conflicts: # Cargo.lock # state-chain/cf-integration-tests/Cargo.toml # state-chain/cf-integration-tests/src/authorities.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-810
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
See linked issue. This fixes it. Basically the underlying stream was being created as many times as there were active epochs, but now we just clone a channel of the underlying stream, so the logging (or any other work on the chainsource) isn't done multiple times.