Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move graal from experimental to main. #202

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Jan 7, 2023

We got some feedback that this approach works and we can remove experimental!

Signed-off-by: Dan Lorenc dlorenc@chainguard.dev

@dlorenc dlorenc requested a review from a team as a code owner January 7, 2023 00:14
@dlorenc dlorenc requested review from kaniini and removed request for a team January 7, 2023 00:14
We got some feedback that this approach works and we can remove experimental!

Signed-off-by: Dan Lorenc <dlorenc@chainguard.dev>
@dlorenc dlorenc merged commit a5ba81b into chainguard-images:main Jan 7, 2023
@tisonkun
Copy link

tisonkun commented Jan 7, 2023

Thank you! I'm releasing v1.2.0 for korandoru/hawkeye, whose Native Image Docker image is based on this image. Its usage is verified on my projects that use it.

@tisonkun
Copy link

tisonkun commented Jan 7, 2023

Does this PR mean that we can use a stable tag rather than latest to refer the image now?

@dlorenc
Copy link
Contributor Author

dlorenc commented Jan 7, 2023

Does this PR mean that we can use a stable tag rather than latest to refer the image now?

Normally it would, but there's not really anything in this image for us to anchor the versioning off of (for example, with Python we'd generate a stable tag for something like 3.11.1). For this image it's just glibc and a few other packages, so we don't have something to anchor the tag to.

If there's a specific tagging scheme you'd like to see here we can definitely work it in!

@dlorenc dlorenc deleted the graalexp branch January 7, 2023 15:16
@tisonkun
Copy link

tisonkun commented Jan 7, 2023

@dlorenc That's reasonable. Then I'll keep the current way unless we find something needs a tag different than latest. I may expect nothing will be changed in this image except version bump of glibc, libz, etc. to make to work with latest GraalVM.

@dlorenc
Copy link
Contributor Author

dlorenc commented Jan 7, 2023

Thanks, that's our intention here too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants