Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, the scaffolding chart uses trillian which rely on toolbelt/nc image. that image is amd64 only which then make the scaffolding chart requires amd64 node.
https://github.com/sigstore/helm-charts/blob/a80c33c8ca6f3c37d9b1dcb4dab14ca625f77831/charts/trillian/values.yaml#L160
Fixes:
Related:
Pre-review Checklist
For new image PRs only
If you have an apko.yaml file in this PR you need to follow this checklist, otherwise feel free to remove.
Image is marked experimental or stable as appropriate
The last two minor versions are available
The latest tag points to the newest stable version
There is a dev tag available that includes a shell and apk tools (by depending on 'wolfi-base')
The image runs as
nonroot
and GID/UID are set to 65532ENTRYPOINT
CMD:
–help
Consider where and how the image deviates from popular alternatives. Is there a good reason and is it documented?
Add annotations e.g:
Check if environment variables are needed e.g. to set data locations
Ensure the image responds to SIGTERM
docker kill $(docker run -d --rm cgr.dev/chainguard/nginx)
Documentation. Let's make this excellent. Include usage example.
Error logs write to stderr and normal logs to stdout. DO NOT write to file.
Include tests, at the very least a basic smoke test.