Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external-dns image. #410

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Mar 31, 2023

Fixes:

Related:

Pre-review Checklist

  • IMPORTANT: 'image-request' tag has been applied if this PR is adding any images, including new versions or variants

For new image PRs only

If you have an apko.yaml file in this PR you need to follow this checklist, otherwise feel free to remove.

  • Image is marked experimental or stable as appropriate
  • The last two minor versions are available
  • The latest tag points to the newest stable version
  • There is a dev tag available that includes a shell and apk tools (by depending on 'wolfi-base')
  • The image runs as nonroot and GID/UID are set to 65532
    • Alternatively the username and GID/UID may be a commonly used one from the ecosystem e.g: postgres
    • See above for exceptions to nonroot rule
  • X ] ENTRYPOINT
    • For applications/servers/utilities call main program with no arguments e.g. [redis-server]
  • CMD:
    • For utilities/tooling bring up help e.g. –help
  • Consider where and how the image deviates from popular alternatives. Is there a good reason and is it documented?
  • Add annotations e.g:
annotations:
  "org.opencontainers.image.authors": "Chainguard Team https://www.chainguard.dev/"
  "org.opencontainers.image.url": https://edu.chainguard.dev/chainguard/chainguard-images/reference/busybox/ # use the academy site here
  "org.opencontainers.image.source": https://github.com/chainguard-images/images/tree/main/images/bazel # use github here
  • Check if environment variables are needed e.g. to set data locations
  • Ensure the image responds to SIGTERM
    • docker kill $(docker run -d --rm cgr.dev/chainguard/nginx)
  • Documentation. Let's make this excellent. Include usage example.
  • Error logs write to stderr and normal logs to stdout. DO NOT write to file.
  • Include tests, at the very least a basic smoke test.

Signed-off-by: Dan Lorenc <dlorenc@chainguard.dev>
@dlorenc dlorenc added the image-request tag for new chainguard image requests label Mar 31, 2023
@dlorenc dlorenc requested a review from a team as a code owner March 31, 2023 11:41
@dlorenc dlorenc requested review from luhring and removed request for a team March 31, 2023 11:41
@jdolitsky jdolitsky merged commit 3a21c06 into chainguard-images:main Mar 31, 2023
@dlorenc dlorenc deleted the externaldns branch May 14, 2023 16:26
developer-guy pushed a commit to Dentrax/images that referenced this pull request Feb 12, 2024
* add 1.19

Signed-off-by: James Strong <strong.james.e@gmail.com>

* add mount/umount and add 1.19

Signed-off-by: James Strong <strong.james.e@gmail.com>

* yaming it up

Signed-off-by: James Strong <strong.james.e@gmail.com>

---------

Signed-off-by: James Strong <strong.james.e@gmail.com>
xnox added a commit to xnox/images that referenced this pull request May 16, 2024
This brings in the following changes:

ba1a9c9 (HEAD -> main, upstream/main, upstream/HEAD) update action to use new c>
77965ce Bump tj-actions/changed-files from 44.3.0 to 44.4.0 (chainguard-images#429)
25a26c8 upgrade arifact actions to v4 (chainguard-images#432)
b71790d update ci tests (chainguard-images#431)
4a4a027 bump kind to v0.23.0 add 1.30 k8s / remove 1.23/24 and updates kindest/>
3d3cb8d Bump step-security/harden-runner from 2.7.0 to 2.7.1 (chainguard-images#425)
73d51cb Bump actions/setup-go from 5.0.0 to 5.0.1 in /boilerplate (chainguard-images#426)
1105f78 Bump actions/setup-go from 5.0.0 to 5.0.1 (chainguard-images#427)
67c8811 Bump actions/checkout from 4.1.3 to 4.1.5 (chainguard-images#428)
97bd985 deprecate setup-chainctl in favor of the other repo (chainguard-images#399)
8799517 Bump actions/upload-artifact from 4.3.2 to 4.3.3 in /kind-diag (chainguard-images#422)
4995b58 Update README.md (chainguard-images#423)
bcf69bc Bump actions/upload-artifact from 4.3.1 to 4.3.2 in /kind-diag (chainguard-images#419)
7576b91 Bump tj-actions/changed-files from 44.0.1 to 44.3.0 (chainguard-images#420)
9bad65a Bump actions/checkout from 4.1.2 to 4.1.3 (chainguard-images#421)
270ade7 Bump tj-actions/changed-files from 44.0.0 to 44.0.1 (chainguard-images#415)
2cadca1 Bump actions/checkout from 4.1.1 to 4.1.2 (chainguard-images#406)
4f1d9b7 Bump reviewdog/action-setup from 1.2.1 to 1.3.0 in /boilerplate (chainguard-images#405)
d052d8b Bump reviewdog/action-setup from 1.2.1 to 1.3.0 in /donotsubmit (chainguard-images#407)
0e99253 Don't triple-wrap logs, just upload as zip (chainguard-images#410)
48e6493 Bump tj-actions/changed-files from 43.0.1 to 44.0.0 (chainguard-images#413)
7071df0 update changed-files (chainguard-images#412)

Given there are no releases of chainguard-dev actions, and bots do not
bump commit ids, maybe we should switch back to tracking @main like we
used to.

Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@chainguard.dev>
k4leung4 pushed a commit that referenced this pull request May 21, 2024
This brings in the following changes:

ba1a9c9 (HEAD -> main, upstream/main, upstream/HEAD) update action to use new c>
77965ce Bump tj-actions/changed-files from 44.3.0 to 44.4.0 (#429)
25a26c8 upgrade arifact actions to v4 (#432)
b71790d update ci tests (#431)
4a4a027 bump kind to v0.23.0 add 1.30 k8s / remove 1.23/24 and updates kindest/>
3d3cb8d Bump step-security/harden-runner from 2.7.0 to 2.7.1 (#425)
73d51cb Bump actions/setup-go from 5.0.0 to 5.0.1 in /boilerplate (#426)
1105f78 Bump actions/setup-go from 5.0.0 to 5.0.1 (#427)
67c8811 Bump actions/checkout from 4.1.3 to 4.1.5 (#428)
97bd985 deprecate setup-chainctl in favor of the other repo (#399)
8799517 Bump actions/upload-artifact from 4.3.2 to 4.3.3 in /kind-diag (#422)
4995b58 Update README.md (#423)
bcf69bc Bump actions/upload-artifact from 4.3.1 to 4.3.2 in /kind-diag (#419)
7576b91 Bump tj-actions/changed-files from 44.0.1 to 44.3.0 (#420)
9bad65a Bump actions/checkout from 4.1.2 to 4.1.3 (#421)
270ade7 Bump tj-actions/changed-files from 44.0.0 to 44.0.1 (#415)
2cadca1 Bump actions/checkout from 4.1.1 to 4.1.2 (#406)
4f1d9b7 Bump reviewdog/action-setup from 1.2.1 to 1.3.0 in /boilerplate (#405)
d052d8b Bump reviewdog/action-setup from 1.2.1 to 1.3.0 in /donotsubmit (#407)
0e99253 Don't triple-wrap logs, just upload as zip (#410)
48e6493 Bump tj-actions/changed-files from 43.0.1 to 44.0.0 (#413)
7071df0 update changed-files (#412)

Given there are no releases of chainguard-dev actions, and bots do not
bump commit ids, maybe we should switch back to tracking @main like we
used to.

Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@chainguard.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
image-request tag for new chainguard image requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants