downloadOsmNetworkData: fail if output directory does not exist

[davidmurray]

With a brand new instance of Transition, the runtime/imports does not exist. The download task will fail:

davidmurray@Davids-MBP-2 transition % yarn node --max-old-space-size=4096 packages/chaire-lib-backend/lib/scripts/osrm/downloadOsmNetworkData.task.js --polygon-file polygon_mtl.geojson 
yarn node v1.22.19
Using .env file from /Users/davidmurray/code/poly/transition/.env
Read server configuration from /Users/davidmurray/code/poly/transition/config.js
Retrieving data from osm...
Done retrieving data from osm...
Writing osm data to /Users/davidmurray/code/poly/transition/runtime//imports/osm_network_data.osm
Error download from API [Error: ENOENT: no such file or directory, open '/Users/davidmurray/code/poly/transition/runtime//imports/osm_network_data.osm'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/Users/davidmurray/code/poly/transition/runtime//imports/osm_network_data.osm'
}
task did not complete correctly [Error: ENOENT: no such file or directory, open '/Users/davidmurray/code/poly/transition/runtime//imports/osm_network_data.osm'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/Users/davidmurray/code/poly/transition/runtime//imports/osm_network_data.osm'
}
✨  Done in 5.15s.

[greenscientist]

Do you have a runtime directory or both are missing?

[davidmurray]

Do you have a runtime directory or both are missing?

I think both were missing!
It's the first thing I ran after git clone, yarn setup, compile, migrate and create-user.

[greenscientist]

From a potential PR: " the task should at least fail cleanly, so it should at least check if the directory is present and print an error message saying that the directly is invalid and suggest appropriate steps."
We will do at least that.