Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build latex definition in CI #1116

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

greenscientist
Copy link
Collaborator

To insure that the latex file are not corrupted, let's build them in the CI

Closes: #1111

@greenscientist greenscientist force-pushed the buildlatexci branch 7 times, most recently from 0e5ba86 to 81a40d0 Compare November 27, 2024 00:28
@GabrielBruno24
Copy link
Collaborator

GabrielBruno24 commented Nov 27, 2024

With the way this is set up this doesn't actually run the action on this PR. Can you make a small trivial change in the tex files so that it will actually run and we can check it works correctly?
Maybe also push once with an invalid file to see what happens when it fails.

@greenscientist
Copy link
Collaborator Author

With the way this is set up this doesn't actually run the action on this PR. Can you make a small trivial change in the tex files so that it will actually run and we can check it works correctly? Maybe also push once with an invalid file to see what happens when it fails.

It was tested without the path filter to ensure it works well. (See the commit/action history).
It's the same parttern that we use for the osrm profiles, so this will work. I'd like to avoid commiting unnecessary changes to the repo.

@greenscientist
Copy link
Collaborator Author

@GabrielBruno24 , I added a commit with a broken tex file. It was run and detected properly. I'll remove the commit, but you can see it with hash 24ffc70

To insure that the latex file are not corrupted, let's build them in the CI

Closes: chairemobilite#1111
@tahini tahini merged commit 5b43198 into chairemobilite:main Dec 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add job to compile latex documentation into PDF to validate it.
4 participants