nodes db: return an empty data field for the geojson collection #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `data` field is mandatory in the `NodesAttributes`, but it was just dropped from the geojson collection. We instead return an empty object for data, to make sure it exists.
kaligrafy
approved these changes
Dec 19, 2024
|
Instead of this, should we make it optional and have the people who access it check if it exist? |
|
If we do this, should we undo ee4cddb ??? |
|
we can't make it optional, this is a field in GenericObject !!! (but this may also evolve, with the change of uuid to numeric IDs, we won't be able to extend GenericObject as is anymore and we can think of a new and improved way to implement common features in object, using composition and interfaces instead of inheritance, but that's in the long term) But indeed, we can revert ee4cddb |
…laces" This reverts commit ee4cddb. The data field is now returned as an empty object, so it will always be defined again.
greenscientist
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
datafield is mandatory in theNodesAttributes, but it was just dropped from the geojson collection. We instead return an empty object for data, to make sure it exists.