Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move navigation buttons to top of panel and add margin at the bottom of lines collapsible #758

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

davidmurray
Copy link
Collaborator

For second commit, looks like this now:
image

@davidmurray davidmurray requested a review from kaligrafy November 9, 2023 17:15
@davidmurray davidmurray marked this pull request as draft November 9, 2023 17:29
Copy link
Collaborator

@kaligrafy kaligrafy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the config.js file from commit. I approve the rest!

@davidmurray
Copy link
Collaborator Author

sorry i keep committing that! I'll add it to my gitignore
Anyways I will rewrite this PR to make the buttons float in the header at all times. Will be much better

Otherwise, all agencies and lines are stuck together visually and it's hard to distinguish what goes with what.
@davidmurray davidmurray marked this pull request as ready for review November 9, 2023 21:13
@davidmurray
Copy link
Collaborator Author

davidmurray commented Nov 9, 2023

Ready for review @kaligrafy

Here is what it does:

Screen.Recording.2023-11-09.at.16.06.51.mov

@kaligrafy
Copy link
Collaborator

cool!

Fixes chairemobilite#757

Make the form header stick to the top so it's always visible.
Also reduce button sizes.
@davidmurray davidmurray merged commit 6f6f0fe into chairemobilite:main Nov 9, 2023
4 checks passed
@davidmurray davidmurray deleted the fix-757 branch November 9, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants