Add DistanceUnitFormatter and DurationUnitFormatter, two react compon… #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could also add one for speeds : m/s, km/h, mph, etc |
kaligrafy
approved these changes
Nov 22, 2023
|
Very nice! |
fixed! |
davidmurray
force-pushed
the
fix-775
branch
2 times, most recently
from
83c3a2c to
5a52ba0
Compare
|
added |
tahini
requested changes
Nov 22, 2023
| const DistanceUnitFormatter: React.FunctionComponent<DistanceUnitFormatterProps> = ( | ||
| props: DistanceUnitFormatterProps | ||
| ) => { | ||
| const [destinationUnit, setDestinationUnit] = useState<string | undefined>(props.destinationUnit); |
There was a problem hiding this comment.
Instead of string, you can use your destinationUnitOptionType
| const DurationUnitFormatter: React.FunctionComponent<DurationUnitFormatterProps> = ( | ||
| props: DurationUnitFormatterProps | ||
| ) => { | ||
| const [destinationUnit, setDestinationUnit] = useState<string | undefined>(props.destinationUnit); |
There was a problem hiding this comment.
Same here, use destiantionUnitOptionsType
…matically choose the best unit for a value They also allow clicking on the values to cycle between the different possible units. Example usage is shown in transit routing output for the walking mode, and route statistics for speed. Fixes chairemobilite#775
|
@tahini fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ents to automatically choose the best unit for a value
They also allow clicking on the values to cycle between the different possible units. Example usage is shown in transit routing output for the walking mode. If code and UX seems satisfactory to you, I will use these components in many other parts of transition.
Demo:
Screen.Recording.2023-11-22.at.11.20.26.mov
Fixes #775