add a checkbox to path edit form to allow ignore #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please test in the ui as well. I have problems with my localhost config and I can't test json2Capnp and osrm right now, so can't test the paths themselves. |
|
The test failure looks legit |
|
The ignore checkbox does not seem to have any effect... My nodes have a dwell time of 20 seconds, I put 10, and whether I ignore or not, the stats are the same. If I change the dwell time of the nodes to 10, then the stats do decrease, so it's really the ignore checkbox not working. |
|
But your unit test failing may be a sign of something wrong, maybe if you fix the test, it will all be fixed! |
kaligrafy
force-pushed
the
addIgnoreNodesDefaultDwellTimeInPath
branch
from
f6e82a5 to
952a6e0
Compare
tahini
requested changes
Nov 29, 2023
tahini
reviewed
Nov 29, 2023
packages/transition-common/src/services/path/__tests__/Path.test.ts
Outdated
Show resolved
Hide resolved
kaligrafy
force-pushed
the
addIgnoreNodesDefaultDwellTimeInPath
branch
from
952a6e0 to
57dfb8c
Compare
tahini
requested changes
Nov 29, 2023
kaligrafy
force-pushed
the
addIgnoreNodesDefaultDwellTimeInPath
branch
from
57dfb8c to
19c60b0
Compare
tahini
requested changes
Nov 29, 2023
packages/transition-common/src/services/path/__tests__/PathData.test.ts
Outdated
Show resolved
Hide resolved
kaligrafy
force-pushed
the
addIgnoreNodesDefaultDwellTimeInPath
branch
from
19c60b0 to
14602b0
Compare
default dwell times for associated nodes, and add help to default dwell time
kaligrafy
force-pushed
the
addIgnoreNodesDefaultDwellTimeInPath
branch
from
14602b0 to
ae2fbc6
Compare
tahini
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default dwell times for associated nodes, and add help to default dwell time