Type the event manager and the map.updateLayer event
#798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to use a type for the events, with a `name` and `args`
fields for the name of the event and types of arguments in the callback.
The methods are generic, with the generic type being the type of the
event. The listening method is `onEvent`, the emitting one is
`emitEvent`. It can be called in the code with
`eventManager.emitEvent<MyEventType>('event.myevent', myArgs)`
`eventManager.onEvent<MyEventType>('event.myevent', (myArgs) => void)`
Add unit tests for these new methods.
Use the new `onEvent` and `emitEvent` methods of the EventManager to type the calls to `map.updateLayer`. It receives an argument with 2 fields: `layerName` and `data`, which are respectively the layer to update and the geojson feature collection for the layer (or function to retrieve it).
tahini
force-pushed
the
typeEventManager
branch
from
0848873 to
be5c178
Compare
|
@kaligrafy ping on this review |
kaligrafy
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use a type for the events, with a
nameandargsfields for the name of the event and types of arguments in the callback.The methods are generic, with the generic type being the type of the event. The listening method is
onEvent, the emitting one isemitEvent. It can be called in the code witheventManager.emitEvent<MyEventType>('event.myevent', myArgs)eventManager.onEvent<MyEventType>('event.myevent', (myArgs) => void)map.updateLayereventUse the new
onEventandemitEventmethods of the EventManager to type the calls tomap.updateLayer. It receives an argument with 2 fields:layerNameanddata, which are respectively the layer to update and the geojson feature collection for the layer (or function to retrieve it).