Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs: Add a column for end time/duration #814

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

tahini
Copy link
Collaborator

@tahini tahini commented Dec 18, 2023

No description provided.

And add unit tests for this function
@tahini tahini requested a review from kaligrafy December 18, 2023 18:56
@greenscientist
Copy link
Collaborator

Is an endtime or a duration kind of confusing to have both at the same place no?

@tahini
Copy link
Collaborator Author

tahini commented Dec 18, 2023

It looks like this

Capture d’écran du 2023-12-18 14-07-00

I'm still waiting for suggestions to make this job list prettier, maybe the docker build list (but we don't see the duration)?

@greenscientist
Copy link
Collaborator

The docker build list for exmple only has a start time and a duration.
out of a start_time, end_time and duration, you only really need 2. The other can be infered with the other.
Personnally, I think the duration is the field that people are probably most interested in

@tahini
Copy link
Collaborator Author

tahini commented Dec 18, 2023

And that might be a problem too if the task has spent time in a pending state... this PR gives a duration from last updated_at to created_at, but we don't have a started_at field...

@tahini
Copy link
Collaborator Author

tahini commented Dec 18, 2023

But adding a started_at is a bit more involving than this quick one...

@greenscientist
Copy link
Collaborator

So the current displayed duration might be a lie?
I was under the impression that this PR looked too easy for what it was...

@tahini tahini marked this pull request as draft December 18, 2023 19:42
@tahini
Copy link
Collaborator Author

tahini commented Dec 18, 2023

#815 needs to be fixed first so we can calculate the actual duration of the job execution and not just it's life

@tahini
Copy link
Collaborator Author

tahini commented Dec 18, 2023

Actually, I can just put the end time in this PR for now, without fixing either #813 or #815. it gives an information to the user, without lying about anything. Would that be all right? @greenscientist ?

@greenscientist
Copy link
Collaborator

Yes, that would work well for the moment and give a good enough insight to the user

If the job is completed or has failed, the column displays the end time
of the task.
@tahini tahini marked this pull request as ready for review December 18, 2023 20:02
@tahini
Copy link
Collaborator Author

tahini commented Dec 18, 2023

Only the end time is present now

@tahini tahini merged commit 6fdef57 into chairemobilite:main Dec 18, 2023
4 checks passed
@tahini tahini deleted the fix813 branch December 18, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants