decoding: always clone strings. fixes #508

chaisql · Nov 26, 2023 · 84a6c9e · 84a6c9e
1 parent acfecdc
commit 84a6c9e
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/internal/database/encoding.go b/internal/database/encoding.go
@@ -2,6 +2,7 @@ package database
 
 import (
 	"encoding/binary"
+	"strings"
 
 	"github.com/cockroachdb/errors"
 	"github.com/genjidb/genji/document"
@@ -190,6 +191,11 @@ func (e *EncodedDocument) decodeValue(fc *FieldConstraint, b []byte) (types.Valu
 		}
 	}
 
+	if v.Type() == types.TextValue {
+		s := strings.Clone(types.As[string](v))
+		v = types.NewTextValue(s)
+	}
+
 	return v, n, nil
 }