Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xplat-intl: localeCompare fails #4623

Closed
obastemur opened this issue Jan 31, 2018 · 0 comments
Closed

xplat-intl: localeCompare fails #4623

obastemur opened this issue Jan 31, 2018 · 0 comments
Labels
Bug
Milestone
1.8

Comments

@obastemur
Copy link
Collaborator 

"0".localeCompare("1") ==> 0

expected 1

looks like https://github.com/Microsoft/ChakraCore/blob/release/1.8/lib/Runtime/Library/IntlEngineInterfaceExtensionObject.cpp#L1385 was the cause.

Sending the fix. /cc @dilijev @jackhorton we better default to non-intl behavior then a default number approach. If you know a similar case, please open an issue or send a PR.
@obastemur obastemur added the Bug label Jan 31, 2018
@obastemur obastemur added this to the 1.8 milestone Jan 31, 2018
@obastemur obastemur mentioned this issue Jan 31, 2018
Merged
chakrabot pushed a commit that referenced this issue Jan 31, 2018
@obastemur
[1.8>1.9] [MERGE #4625 @obastemur] xplat-intl: default to non intl co…
9f40fcb 
…mpare for localeCompare

Merge pull request #4625 from obastemur:xplat_intl_local_comp

Fixes #4623

Also enabling a test case that only tests the interface.
chakrabot pushed a commit that referenced this issue Feb 1, 2018
@obastemur
[1.9>master] [1.8>1.9] [MERGE #4625 @obastemur] xplat-intl: default t…
7e8b35d 
…o non intl compare for localeCompare

Merge pull request #4625 from obastemur:xplat_intl_local_comp

Fixes #4623

Also enabling a test case that only tests the interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
1 participant
@obastemur