Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTD -- Updates to debug integration and log optimization. #2853

Merged
merged 1 commit into from
May 2, 2017
Merged

TTD -- Updates to debug integration and log optimization. #2853

merged 1 commit into from
May 2, 2017

Conversation

mrkmarron
Copy link
Contributor

  • Refactored debugger interaction code into seperate file.
  • Only notify debugger of first load of a source file.
  • Ensure all sources have unique id (shared with debugger) even when re-created.
  • Breakpoints are loaded incrementally.
  • Updated reverse continue logic.
  • Improve log representation memory usage.
  • Fix weak set/map handling to remove memory leak in recording.
  • Improve handling of long-lived external reference tracking in log (addref and makeweak).

Copy link
Contributor

@kfarnung kfarnung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chakrabot chakrabot merged commit 1945e02 into chakra-core:release/2.0 May 2, 2017
chakrabot pushed a commit that referenced this pull request May 2, 2017
…optimization.

Merge pull request #2853 from mrkmarron:TTDUpdates

- Refactored debugger interaction code into seperate file.
- Only notify debugger of first load of a source file.
- Ensure all sources have unique id (shared with debugger) even when re-created.
- Breakpoints are loaded incrementally.
- Updated reverse continue logic.
- Improve log representation memory usage.
- Fix weak set/map handling to remove memory leak in recording.
- Improve handling of long-lived external reference tracking in log (addref and makeweak).
chakrabot pushed a commit that referenced this pull request May 2, 2017
…tion and log optimization.

Merge pull request #2853 from mrkmarron:TTDUpdates

- Refactored debugger interaction code into seperate file.
- Only notify debugger of first load of a source file.
- Ensure all sources have unique id (shared with debugger) even when re-created.
- Breakpoints are loaded incrementally.
- Updated reverse continue logic.
- Improve log representation memory usage.
- Fix weak set/map handling to remove memory leak in recording.
- Improve handling of long-lived external reference tracking in log (addref and makeweak).
@mrkmarron mrkmarron deleted the TTDUpdates branch May 21, 2017 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants