Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for not defined identifier; update baselines. Fixes #2901. #2903

Merged
merged 1 commit into from
May 9, 2017
Merged

Improve error message for not defined identifier; update baselines. Fixes #2901. #2903

merged 1 commit into from
May 9, 2017

Conversation

dilijev
Copy link
Contributor

@dilijev dilijev commented May 2, 2017

Fixes #2901
Ref #2658

@dilijev dilijev requested review from bterlson and akroshg May 2, 2017 20:46
@dilijev
Copy link
Contributor Author

dilijev commented May 2, 2017

/cc @bterlson @akroshg can you review?

@chakrabot chakrabot merged commit 64c9c20 into chakra-core:release/2.0 May 9, 2017
chakrabot pushed a commit that referenced this pull request May 9, 2017
@dilijev
[MERGE #2903 @dilijev] Improve error message for not defined identifi…
ebf6bb0 
…er; update baselines. Fixes #2901.

Merge pull request #2903 from dilijev:not-def

Fixes #2901
Ref #2658
@dilijev dilijev deleted the not-def branch May 9, 2017 01:55
chakrabot pushed a commit that referenced this pull request May 10, 2017
@dilijev
[2.0>master] [MERGE #2903 @dilijev] Improve error message for not def…
af28cef 
…ined identifier; update baselines. Fixes #2901.

Merge pull request #2903 from dilijev:not-def

Fixes #2901
Ref #2658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfarnung kfarnung kfarnung approved these changes

@bterlson bterlson bterlson approved these changes

@akroshg akroshg Awaiting requested review from akroshg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dilijev @bterlson @kfarnung @msftclas @chakrabot