WASM.SIMD Comparison ops for 32x4 types #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing flag
Krovatkin
force-pushed
the
wasm.simd.compops2
branch
3 times, most recently
from
d35db92
to
3c332fb
Compare
Krovatkin
force-pushed
the
wasm.simd.compops2
branch
from
3c332fb
to
00a1a3c
Compare
|
@Cellule could you please take a quick look? I'm going to rebase |
|
fyi @arunetm |
|
|
|
@arunetm could you please try to merge this? |
|
@MikeHolman @Cellule Guys, could you please help us to merge this one? Arun is still figuring out his perms issue. |
|
@Cellule @MikeHolman very sorry to nudge you, guys, again about this PR. Could you please merge it when you have a moment? |
chakrabot
pushed a commit
that referenced
this pull request
Jul 24, 2017
Merge pull request #3348 from Krovatkin:wasm.simd.compops2 This PR includes * enable comparison operations + tests * binary arithmetic operations + tests * unary arithmetic operations + tests * flag fix to make sure we can pass around v128 within the same wasm module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes