string-test: fix localCompare test #4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @jackhorton |
|
I was confused that 1.9 and Master output 0, 48 and -20 for these cases whilst 1.8 still outputs 0, 1 and -1. (Considering the only relevant PR I could see was put into all 3) |
MSLaguana
reviewed
Feb 1, 2018
test/Strings/rlexe.xml
Outdated
| @@ -105,7 +105,7 @@ | |||
| <test> | |||
| <default> | |||
| <files>compare.js</files> | |||
| <baseline>compare.baseline</baseline> | |||
| <baseline/> | |||
There was a problem hiding this comment.
If there's no baseline now, I'd prefer to remove the <baseline/> tag completely.
There was a problem hiding this comment.
I don't have a strong op. on that, so removed.
obastemur
force-pushed
the
fix_test_strcmp
branch
from
57929e3
to
497d3d9
Compare
MSLaguana
approved these changes
Feb 1, 2018
|
@MSLaguana Thanks for the review! |
chakrabot
pushed a commit
that referenced
this pull request
Feb 1, 2018
Merge pull request #4632 from obastemur:fix_test_strcmp spec asks for `<`, `=`, or `>` while our baseline was expecting a particular output.
chakrabot
pushed a commit
that referenced
this pull request
Feb 1, 2018
Merge pull request #4632 from obastemur:fix_test_strcmp spec asks for `<`, `=`, or `>` while our baseline was expecting a particular output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec asks for
<,=, or>while our baseline was expecting a particular output.