"should include_json_expression" matchers #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @iangreenleaf, sorry for the holdup. I'm working on a 2.0 branch and I'll decide if this is a good fit when I have a stable 2.0 base to determine what features to include, should be soonish :) |
|
Still not sure if we really need this. Feel free to re-open when #18 is implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted a more visible set of matchers for the common task of testing against a subset of a hash. It's doable with the "strictness" setting, but I found that one a little obscure and difficult to discover. Hopefully you like this new version.
I didn't write any documentation - I figured you could decide how you wanted to organize it, if you decide to pull this feature.