This repository has been archived by the owner on Sep 25, 2021. It is now read-only.
#484, update pinned thread titles for newly posted threads when possible #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base with the dirty flag
|
At this point I'm not going to submit any other pull requests. I think that the 8 I put in are plenty more than enough. If anyone's reading this, they can find a debug multi-release of all the features from the pulls here. |
| * The thread title will be updated as soon as the site has the thread listed in the thread directory | ||
| * | ||
| */ | ||
| pin.loadable.setTitle(PostHelper.getTitle(thread.op, pin.loadable)); |
There was a problem hiding this comment.
not sure how expensive .setTitle is, but maybe we should .setTitle only if the current pin.loadable.title does not equal PostHelper.getTitle(thread.op, pin.loadable). something like:
if (!pin.loadable.getTitle().equals(PostHelper.getTitle(thread.op, pin.loadable)) {
pin.loadable.setTitle(PostHelper.getTitle(thread.op, pin.loadable));
}
minor thing really I think, so not needed
|
This might also be a solution to #450, but it might not. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have left an explanation as a comment.