Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create a PR if all changesets are empty #206

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

glasser
Copy link
Contributor

@glasser glasser commented Aug 18, 2022

Fixes #205.

Note that this maintains the previous behavior that if there are any
changesets (even empty ones), the action does not publish packages.

Fixes changesets#205.

Note that this maintains the previous behavior that if there are any
changesets (even empty ones), the action does not publish packages.
@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2022

🦋 Changeset detected

Latest commit: 452c4ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/action Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@glasser
Copy link
Contributor Author

glasser commented Aug 18, 2022

I didn't add a test because index.ts has no tests and I was a bit intimidated by the idea of writing the first one.

@Andarist Andarist merged commit 8c3f5f5 into changesets:main Aug 18, 2022
@github-actions github-actions bot mentioned this pull request Aug 18, 2022
cometkim pushed a commit to cometkim/yarn-changeset-action that referenced this pull request Apr 11, 2023
…#206)

* Don't create a PR if all changesets are empty

Fixes changesets#205.

Note that this maintains the previous behavior that if there are any
changesets (even empty ones), the action does not publish packages.

* Create three-needles-protect.md

* Update .changeset/three-needles-protect.md

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If all changesets are empty, the action still creates a PR
2 participants