Add customize PR branch name #370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 813d004 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
reviewed
May 24, 2024
Comment on lines
+31
to
35
| branchName: | ||
| description: Sets the branch name for the pull request. Default to `changeset-release/{{$github.ref_name}}` | ||
| required: false | ||
| branch: | ||
| description: Sets the branch in which the action will run. Default to `github.ref_name` if not provided |
There was a problem hiding this comment.
those 2 inputs are too close to each other
Andarist
reviewed
May 24, 2024
| }: VersionOptions): Promise<RunVersionResult> { | ||
| const octokit = setupOctokit(githubToken); | ||
|
|
||
| let repo = `${github.context.repo.owner}/${github.context.repo.repo}`; | ||
| branch = branch ?? github.context.ref.replace("refs/heads/", ""); | ||
| let versionBranch = `changeset-release/${branch}`; | ||
| let versionBranch = branchName ?? `changeset-release/${branch}`; |
There was a problem hiding this comment.
the problem with this is that we rely on changeset-release/* being the versioning branch:
https://github.com/changesets/bot/blob/492290be72c42ae8f9ba85afe636a7b4520a9909/index.ts#L138-L142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of previous PR #255, it's possible to trigger the Changeset Pull Request process from a branch other than
baseBranch. Thanks for this, it's really useful 🙏If two branches want to merge into
baseBranch, the PR branch name will always bechangeset-release/{{baseBranch}}. In this case, the latest commit will override the branch.But sometimes we just want two different branches. For example, in a Git workflow where the release can come from the
developbranch or thehotfixesbranch.It should be possible to do this workflow with this PR