-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add baseBranch option #373
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 after I took a quick look
Very cool improvement imho.
Could you maybe add the explaination of this change into the README.md
tho? So the documentation is up-to-date...
Accidentally pushed the wrong branch and the PR was closed automatically |
Thanks for the feedback @trueberryless. I added the new action input in the README. Let me know if an example with a full workflow is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🎉
I'll leave the decision for an additional example with the baseBranch option to the actual maintainers, they know it the best...
Closes #368
Change summary
This change adds a new action input
baseBranch
, which allows specifying the branch on which the PR will be opened on. This is useful for hotfixes. In my case, I trigger a release on merging to main, and this change would allow me to open a PR straight to main with the cherry-picked changes.Specifications
A new input,
baseBranch
, can be specified to open the PR onto that branch. If not specified, the behavior will be as before, the PR would be opened on the branch the action runs on.Example
Here's how running a hotfix workflow would look like:
The full workflow can be seen here https://github.com/prenaissance/changesets-test/blob/master/.github/workflows/changesets.yml