Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #424 - Publish in custom artifactory #425

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gethari
Copy link

@gethari gethari commented Nov 19, 2024

Fixes #424

Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: c2796d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/action Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gethari
Copy link
Author

gethari commented Nov 20, 2024

@Andarist, could you kindly review this when you have a moment? I’m relying on this change to get my actions working and would prefer to avoid forking the repository for such a small update. Thank you!

CHANGELOG.md Outdated Show resolved Hide resolved
// check based on https://github.com/npm/cli/blob/8f8f71e4dd5ee66b3b17888faad5a7bf6c657eed/test/lib/adduser.js#L103-L105
return /^\s*\/\/registry\.npmjs\.org\/:[_-]authToken=/i.test(line);
});
const authLine = extractAuthTokenLine(userNpmrcContent);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have mentioned that the previous version of the code goes in to the else branch and that creates a problem. I don't understand this. Even if it goes there... it will just append a different token to ur .npmrc file and that's about it. Your correct token should still be used when publishing to a custom artifactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish in custom artifactory
2 participants