Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Hoff handle external PRs correctly #93

Open
maartenberg opened this issue Oct 14, 2021 · 1 comment
Open

Make Hoff handle external PRs correctly #93

maartenberg opened this issue Oct 14, 2021 · 1 comment

Comments

@maartenberg
Copy link
Member

I've just noticed an issue with merging external PRs that I think we haven't seen before.
When merging channable/vaultenv#113 and channable/vaultenv#115 Hoff did succeed in rebasing the PR, but after Hoff pushed the change to master the PR remained open in Github.

I think this happened because the PRs came from an external repository: if the PR isn't current with the repository's master branch Hoff will rebase the PR and force-push to the branch the PR came from.
Hoff doesn't seem to detect that the branch to push to is in another repository, and it instead seems to have pushed to the original repository (so channable/vaultenv instead of ruuda/vaultenv).

To fix this I think we should alter Hoff to push to the downstream repository instead.
This should be possible if we require the Allow edits from maintainers to be set on external PRs.

@ruuda
Copy link

ruuda commented Oct 15, 2021

Aaah of course, it will force-push, but to the wrong branch! That’s going to be interesting, probably the webhook for pull request updates includes a repository, then Hoff can add that as remote, and try to force-push to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants