Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable line buffering #115

Closed
wants to merge 1 commit into from
Closed

Conversation

ruuda
Copy link
Contributor

@ruuda ruuda commented Oct 13, 2021

When stdout and stderr are not a terminal, like when running under Systemd or Kubernetes, by default the runtime will use block buffering. This prevents log messages from showing up when they are logged, and it breaks interleaving of stdout and stderr. Fix this by explicitly selecting line buffering.

Copy link

@rkrzr rkrzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@maartenberg
Copy link
Member

@OpsBotPrime merge

@OpsBotPrime
Copy link
Contributor

Pull request approved for merge by @maartenberg, waiting for rebase behind one pull request.

@OpsBotPrime
Copy link
Contributor

Rebased as 3efab01, waiting for CI …

@maartenberg
Copy link
Member

Closing: This PR has been merged to master in 3efab01, but because it came from an external repository our mergebot seems to have trouble getting Github to recognize that this PR has been merged.

Thanks for fixing this!

@ruuda ruuda deleted the line-buffering branch October 15, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants