Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GHC from 8.6.5 to 9.0.2 #119

Closed
wants to merge 2 commits into from
Closed

Bump GHC from 8.6.5 to 9.0.2 #119

wants to merge 2 commits into from

Conversation

ReinierMaas
Copy link
Contributor

XRef: #118

Bumps GHC from 8.6.5 to 9.0.2. This is done in preparation for moving to aeson 2.0.*.

@ReinierMaas
Bump GHC from 8.6.5 to 9.0.2
d5d1cc3 
This is done in preperation of moving to `aeson 2.0.*`.
@ReinierMaas ReinierMaas self-assigned this Mar 29, 2022
@ReinierMaas ReinierMaas mentioned this pull request Mar 29, 2022
Closed
crtschin
crtschin approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@crtschin crtschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wonder if we should use the nixpkgs ref of the PR referenced here, which should be merged tomorrow.

@ReinierMaas
Copy link
Contributor Author

The PR was merged but has not propagated to the unstable branch yet.
image

@ReinierMaas
Copy link
Contributor Author

The nixpkgs ref is updated to the latest nixpkgs-unstable. This indeed includes the mentioned PR 🎉.

The continuation on this branch is in #120. Which implemented the aeson bump compatibility code.

@ReinierMaas
Copy link
Contributor Author

This was merged with the bump to aeson 2.0.*

@ReinierMaas ReinierMaas deleted the ghc-8.6.5-to-9.0.2 branch April 19, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crtschin crtschin crtschin approved these changes

Assignees

@ReinierMaas ReinierMaas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReinierMaas @crtschin