Fix the static build #123
Fix the static build #123
Conversation
| glibcLocales = pkgs.glibcLocales; | ||
| }).overrideAttrs (prev: { | ||
| # Disable the check phase, as hspec-discover will not run. | ||
| # TODO: investigate what's happening with hspec-discover. |
There was a problem hiding this comment.
Do you still intend to debug the TODOs? Could you make issues otherwise?
There was a problem hiding this comment.
Both TODO's don't seem overly important.
The first because the tests are run elsewhere anywhere.
The second because it is just a slightly ugly, but still functional, solution.
There was a problem hiding this comment.
The hash of the output path changes when the flags on the input side change. So if it could be set to do the testing that is preferred otherwise this can be left as is.
There was a problem hiding this comment.
It doesn't pick up the tests when enabled.
Since the pkgsStatic.haskellPackages call is, in Falco's words, 'magic', I think I lack the knowledge to debug this.
|
@OpsBotPrime merge |
|
Pull request approved for merge by @Riscky, rebasing now. |
Approved-by: Riscky Auto-deploy: false
|
Rebased as fb5b672, waiting for CI … |
OpsBotPrime
force-pushed
the
riscky/fix-build
branch
from
3845310
to
fb5b672
Compare
The static build has been broken since 4cd7431, due to a package upgrade.
This PR fixes the static build (big thanks to @FPtje).
The new solution is a lot simpler, so some old cruft has been removed.
This also adds the build script to CI so our master will be green in the future.
The machine type of the CI runner has also been changed, as we need more disk apparently.