Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nixpkgs update, and crypton-connection upgrade #140

Merged
merged 7 commits into from
Jul 23, 2024

Conversation

ErnestKz
Copy link
Contributor

@ErnestKz ErnestKz commented Apr 8, 2024

Seems like crypton-connection is superseding connection, and a large portion of the Haskell ecosystem has done the migration. Having both connection and crypton-connection in a project causes a conflict on the tls version.

Links:

@ErnestKz
Copy link
Contributor Author

ErnestKz commented Apr 8, 2024

Package ‘vault-1.16.1’ in /nix/store/wcgy02srky2kn7nlzzrjczss6d15551c-nixpkgs-src/pkgs/tools/security/vault/default.nix:47 has an unfree license (‘bsl11’), refusing to evaluate.

@ErnestKz
Copy link
Contributor Author

ErnestKz commented Apr 9, 2024

After the nixpkgs update, vault has become unfree. It is only a part of the dev dependencies:

vault

@ErnestKz ErnestKz requested a review from Riscky April 10, 2024 11:40
Copy link
Contributor

@Riscky Riscky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ErnestKz
Copy link
Contributor Author

ErnestKz commented Apr 10, 2024

Since this project already works as a binary in it's current release, and doesn't need any functionality changes. We can perform a release once we addressed this issue: #141

@alex-mckenna alex-mckenna mentioned this pull request Jul 23, 2024
@alex-mckenna
Copy link
Contributor

@OpsBotPrime merge

@OpsBotPrime
Copy link
Contributor

Pull request approved for merge by @alex-mckenna, rebasing now.

Approved-by: alex-mckenna
Priority: Normal
Auto-deploy: false
@OpsBotPrime
Copy link
Contributor

Rebased as af4d544, waiting for CI …

@OpsBotPrime
Copy link
Contributor

CI job 🟡 started.

@OpsBotPrime OpsBotPrime merged commit af4d544 into master Jul 23, 2024
1 check passed
@OpsBotPrime OpsBotPrime deleted the nixpkgs-update-connection-upgrade branch July 23, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants