Skip to content

Commit

Permalink
Fix ArrowRightUp icon broken bug by upgrading svgo library (#1896)
Browse files Browse the repository at this point in the history
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue
<!-- Please link to issue if one exists -->

<!-- Fixes #0000 -->

- None

## Summary
<!-- Please brief explanation of the changes made -->

- `ArrowRightUp` icon 이 깨지는 버그를 수정합니다. (**target branch: main**)


![image](https://github.com/channel-io/bezier-react/assets/28595102/31902bd8-d706-4ea0-bdbb-a5d4c3da7f0c)


## Details
<!-- Please elaborate description of the changes -->

- svgo 3.0.3 에서 빌드했을 때는 안깨지다가 3.0.4에서 빌드하면 깨지는 것으로 보아 svgo 라이브러리의 문제라고
추정됩니다.
- 최신 버전(3.2.0)에서 빌드하면 재현이 안되는 것을 확인했기 때문에 최신 버전으로 업그레이드 합니다. 빌드 결과는 커멘트로
달리는 스토리북 프리뷰를 참고해주세요.
- 시각 회귀 테스트가 잘 동작했다면 사전에 방지할 수 있었을 것으로 보입니다
(#1000)

### Breaking change? (Yes/No)
<!-- If Yes, please describe the impact and migration path for users -->

- No

## References
<!-- Please list any other resources or points the reviewer should be
aware of -->

- svgo 3.0.3로 빌드한 스토리북 :
#1725 (comment)
- svgo 3.0.4로 빌드한 스토리북:
#1739 (comment)
  • Loading branch information
yangwooseong authored Jan 10, 2024
1 parent b6b16e9 commit 1093c94
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 11 deletions.
5 changes: 5 additions & 0 deletions .changeset/eight-bananas-care.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@channel.io/bezier-icons": minor
---

Fix `ArrowRightUp` icon broken bug
2 changes: 1 addition & 1 deletion packages/bezier-icons/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"eslint-config-bezier": "workspace:^",
"rollup": "^3.29.1",
"rollup-plugin-visualizer": "^5.9.2",
"svgo": "^3.0.2",
"svgo": "^3.2.0",
"tsconfig": "workspace:^"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ exports[`Help > Snapshot > 1`] = `
>
<path
clip-rule="evenodd"
d="M12 2c5.523 0 10 4.477 10 10s-4.477 10-10 10S2 17.523 2 12 6.477 2 12 2Zm.83 12.541h-1.9v-.708c0-1.156.625-2.24 1.672-2.9.867-.546 1.337-.939 1.337-1.447 0-1.014-1-1.561-1.94-1.561-1.035 0-1.942.73-1.942 1.56h-1.9c0-1.875 1.758-3.46 3.841-3.46 2.154 0 3.842 1.52 3.842 3.46 0 1.655-1.392 2.533-2.225 3.056-.236.15-.784.573-.784 1.292v.708m-.889 3.631a1.244 1.244 0 1 1 0-2.487 1.244 1.244 0 0 1 0 2.487"
d="M12 2c5.523 0 10 4.477 10 10s-4.477 10-10 10S2 17.523 2 12 6.477 2 12 2m.83 12.541h-1.9v-.708c0-1.156.625-2.24 1.672-2.9.867-.546 1.337-.939 1.337-1.447 0-1.014-1-1.561-1.94-1.561-1.035 0-1.942.73-1.942 1.56h-1.9c0-1.875 1.758-3.46 3.841-3.46 2.154 0 3.842 1.52 3.842 3.46 0 1.655-1.392 2.533-2.225 3.056-.236.15-.784.573-.784 1.292zm-.889 3.631a1.244 1.244 0 1 1 0-2.487 1.244 1.244 0 0 1 0 2.487"
fill="currentColor"
fill-rule="evenodd"
/>
Expand Down
18 changes: 9 additions & 9 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2463,7 +2463,7 @@ __metadata:
eslint-config-bezier: "workspace:^"
rollup: ^3.29.1
rollup-plugin-visualizer: ^5.9.2
svgo: ^3.0.2
svgo: ^3.2.0
tsconfig: "workspace:^"
languageName: unknown
linkType: soft
Expand Down Expand Up @@ -9776,7 +9776,7 @@ __metadata:
languageName: node
linkType: hard

"css-tree@npm:^2.2.1":
"css-tree@npm:^2.3.1":
version: 2.3.1
resolution: "css-tree@npm:2.3.1"
dependencies:
Expand Down Expand Up @@ -9819,7 +9819,7 @@ __metadata:
languageName: node
linkType: hard

"csso@npm:5.0.5":
"csso@npm:^5.0.5":
version: 5.0.5
resolution: "csso@npm:5.0.5"
dependencies:
Expand Down Expand Up @@ -19284,20 +19284,20 @@ __metadata:
languageName: node
linkType: hard

"svgo@npm:^3.0.2":
version: 3.0.4
resolution: "svgo@npm:3.0.4"
"svgo@npm:^3.2.0":
version: 3.2.0
resolution: "svgo@npm:3.2.0"
dependencies:
"@trysound/sax": 0.2.0
commander: ^7.2.0
css-select: ^5.1.0
css-tree: ^2.2.1
css-tree: ^2.3.1
css-what: ^6.1.0
csso: 5.0.5
csso: ^5.0.5
picocolors: ^1.0.0
bin:
svgo: ./bin/svgo
checksum: b78aa6f0a2873f41d6e62d68a59c41a706885cd5164c21709461546f26ec2b37a0bb40fd4904c0d39f97a22c61b4b9834baac395aefd44439a0207c25e048a6c
checksum: 42168748a5586d85d447bec2867bc19814a4897f973ff023e6aad4ff19ba7408be37cf3736e982bb78e3f1e52df8785da5dca77a8ebc64c0ebd6fcf9915d2895
languageName: node
linkType: hard

Expand Down

0 comments on commit 1093c94

Please sign in to comment.