Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write mdx documentation for ProgressBar component #1035

Merged
merged 9 commits into from
Nov 30, 2022

Conversation

Dogdriip
Copy link
Contributor

@Dogdriip Dogdriip commented Nov 17, 2022

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [ ] [Component] I wrote a unit test about the implementation.
  • [ ] [Component] I wrote a storybook document about the implementation.
  • [ ] [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

Closes #1034

Summary

  • ProgressBar 컴포넌트에 대한 mdx documentation을 작성합니다.

Details

  • Storybook preview 확인 후 첨삭 부탁드립니다 🙏

Breaking change or not (Yes/No)

No.

References

@Dogdriip Dogdriip added documentation Issue or PR that improvements or additions to documentation component labels Nov 17, 2022
@Dogdriip Dogdriip self-assigned this Nov 17, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2022

⚠️ No Changeset found

Latest commit: 26e5541

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 71.19% // Head: 71.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (26e5541) compared to base (fe9640b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1035   +/-   ##
========================================
  Coverage    71.19%   71.20%           
========================================
  Files          208      208           
  Lines         2979     2980    +1     
  Branches       822      822           
========================================
+ Hits          2121     2122    +1     
  Misses         739      739           
  Partials       119      119           
Impacted Files Coverage Δ
...r-react/src/components/ProgressBar/ProgressBar.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2022

Chromatic Report

🚀 Congratulations! Your build was successful!

@Dogdriip Dogdriip marked this pull request as ready for review November 17, 2022 14:06

## Overview

진행도를 나타낼 때 사용합니다.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 채워주실 내용이 있다면 브랜치로 직접 푸시해 주시거나 코멘트 달아주시면 감사하겠습니다!

Comment on lines +69 to +71
const handleSetRandomValues = () => {
setValues([...Array(4)].map(() => Math.random()))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후 크로마틱의 UI 스냅샷 기능을 제대로 사용하게 될 경우, 이 함수는 매 빌드마다 일정하지 않은 값을 반환하게 되므로 스냅샷 기능을 제대로 사용할 수 없게 됩니다. 0으로 초기값을 세팅해도 괜찮을 거 같아요! (#1000)

@Dogdriip Dogdriip merged commit c23d64b into channel-io:next-v1 Nov 30, 2022
@Dogdriip Dogdriip deleted the docs/progress-bar branch November 30, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue or PR that improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write documentation for ProgressBar component
4 participants