-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write mdx documentation for ProgressBar
component
#1035
Conversation
|
Codecov ReportBase: 71.19% // Head: 71.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1035 +/- ##
========================================
Coverage 71.19% 71.20%
========================================
Files 208 208
Lines 2979 2980 +1
Branches 822 822
========================================
+ Hits 2121 2122 +1
Misses 739 739
Partials 119 119
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Chromatic Report🚀 Congratulations! Your build was successful! |
|
||
## Overview | ||
|
||
진행도를 나타낼 때 사용합니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢 채워주실 내용이 있다면 브랜치로 직접 푸시해 주시거나 코멘트 달아주시면 감사하겠습니다!
packages/bezier-react/src/components/ProgressBar/ProgressBar.mdx
Outdated
Show resolved
Hide resolved
const handleSetRandomValues = () => { | ||
setValues([...Array(4)].map(() => Math.random())) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추후 크로마틱의 UI 스냅샷 기능을 제대로 사용하게 될 경우, 이 함수는 매 빌드마다 일정하지 않은 값을 반환하게 되므로 스냅샷 기능을 제대로 사용할 수 없게 됩니다. 0으로 초기값을 세팅해도 괜찮을 거 같아요! (#1000)
307370b
to
623b55b
Compare
Self Checklist
[ ] [Component] I wrote a unit test about the implementation.[ ] [Component] I wrote a storybook document about the implementation.[ ] [Component] I tested the implementation in various browsers.Windows: Chrome, Edge, (Optional) FirefoxmacOS: Chrome, Edge, Safari, (Optional) Firefox[New Component] I added my username to the correct directory in theCODEOWNERS
file.Related Issue
Closes #1034
Summary
ProgressBar
컴포넌트에 대한 mdx documentation을 작성합니다.Details
Breaking change or not (Yes/No)
No.
References