-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement layered structure of Sass-based styled-system #1484
Implement layered structure of Sass-based styled-system #1484
Conversation
|
Chromatic Report🚀 Congratulations! Your build was successful! |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## alpha #1484 +/- ##
=======================================
Coverage 87.45% 87.45%
=======================================
Files 279 279
Lines 3842 3842
Branches 804 804
=======================================
Hits 3360 3360
Misses 409 409
Partials 73 73 ☔ View full report in Codecov by Sentry. |
615b9bd
to
727788c
Compare
f572df6
to
7c4186a
Compare
* feat(tokens): add core token * feat(tokens): change to mixin * feat(tokens): add semantic tokens * feat(tokens): merge tokens * chore(dev-deps): add sass * fix(tokens): change from underscore to hypen * feat(tokens): implement tokens layer structure * feat(styles): create styles dir and structure * feat(tokens): add bezier namspace to data attr * chore(dev-deps): add css reset * feat(styles): add reset and base layer * feat(styles): enhance monospace font stack * style(styles): change comment type to avoid including in css https://sass-lang.com/documentation/syntax/comments/ * feat(styles): add data attr selector to light theme semantic token * feat(styles): add utilities layer and todo comment
* feat(tokens): add core token * feat(tokens): change to mixin * feat(tokens): add semantic tokens * feat(tokens): merge tokens * chore(dev-deps): add sass * fix(tokens): change from underscore to hypen * feat(tokens): implement tokens layer structure * feat(styles): create styles dir and structure * feat(tokens): add bezier namspace to data attr * chore(dev-deps): add css reset * feat(styles): add reset and base layer * feat(styles): enhance monospace font stack * style(styles): change comment type to avoid including in css https://sass-lang.com/documentation/syntax/comments/ * feat(styles): add data attr selector to light theme semantic token * feat(styles): add utilities layer and todo comment
* feat(tokens): add core token * feat(tokens): change to mixin * feat(tokens): add semantic tokens * feat(tokens): merge tokens * chore(dev-deps): add sass * fix(tokens): change from underscore to hypen * feat(tokens): implement tokens layer structure * feat(styles): create styles dir and structure * feat(tokens): add bezier namspace to data attr * chore(dev-deps): add css reset * feat(styles): add reset and base layer * feat(styles): enhance monospace font stack * style(styles): change comment type to avoid including in css https://sass-lang.com/documentation/syntax/comments/ * feat(styles): add data attr selector to light theme semantic token * feat(styles): add utilities layer and todo comment
Self Checklist
CODEOWNERS
file.Related Issue
Summary
Sass와 CSS cascade layer를 기반으로 새로운 스타일 시스템의 구조를 만듭니다.
Details
Background
기존 의도는 Design token spec에 맞춘 json을 먼저 생성한 후, 이를 기반으로 스타일 시트를 자동 생성하는 것이었습니다.
하지만 아래와 같은 이유로 스타일 시트를 하드 코딩하는 방향으로 초기 구현하기로 결정했습니다.
먼저 새로운 디자인 시스템의 구조를 sass로 구성해보는 것으로 첫 단추를 끼워보려고 합니다.
Details
@layer reset
: for reset css. 새롭게 추가된 레이어입니다.@layer base
: for global style. 사용자 글로벌 스타일에 해당하는 레이어입니다.@layer tokens
: for design token. 디자인 토큰에 해당하는 레이어입니다.ThemeProvider
를 사용한 방식-Foundation
객체 직접 주입-과 다르므로, 이후 다이내믹 테마를 구현할 때 이 점을 고려해야합니다.@layer components
: for component style. 개별 컴포넌트 스타일에 해당하는 레이어입니다.@layer utilities
: for common utilities. 공용 믹스인(typography, elevation) 등의 스타일에 해당하는 레이어입니다.Next
Breaking change or not (Yes/No)
No
References