Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #1609

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Upgrade dependencies #1609

merged 2 commits into from
Sep 11, 2023

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Sep 11, 2023

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Summary

yarn upgrade-interactive 명령어를 통해 의존성을 업데이트합니다. (마이너 버전 범위까지)

Details

  • 5509f35 : 린트 규칙이 충돌하는 현상이 발생하여 비활성화 처리합니다. 채널 eslint 패키지 최신화 및 TS 5.0 업데이트 이후 다시 살펴보려고 합니다.

Breaking change? (Yes/No)

No

@sungik-choi sungik-choi added the chore:deps Issue or PR related to dependencies label Sep 11, 2023
@sungik-choi sungik-choi self-assigned this Sep 11, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

⚠️ No Changeset found

Latest commit: 5509f35

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8c2b873) 87.00% compared to head (5509f35) 87.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1609   +/-   ##
=======================================
  Coverage   87.00%   87.00%           
=======================================
  Files         281      281           
  Lines        3879     3879           
  Branches      817      817           
=======================================
  Hits         3375     3375           
  Misses        430      430           
  Partials       74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi merged commit 772d763 into channel-io:main Sep 11, 2023
11 checks passed
@sungik-choi sungik-choi deleted the deps/upgrade branch September 11, 2023 06:26
sungik-choi added a commit that referenced this pull request Sep 18, 2023
## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Summary
<!-- Please brief explanation of the changes made -->

- rollup `plugin-node-resolve` 의 옵션에 `browser: true` 를 추가하여,
package.json의 exports 필드 중 `browser` 를 함께 확인하도록 수정합니다.
- 이 변경으로 `TextArea` 컴포넌트의 높이가 올바르게 지정되지 않는 문제를 수정합니다.

## Details
<!-- Please elaborate description of the changes -->

`react-textarea-autosize@8.5.0` 버전에서
Andarist/react-textarea-autosize#373 변경사항이
적용되었습니다. 라이브러리의 빌드 최적화 전략이 변경되며 package.json의 exports 필드가 수정되었는데, 기존
브라우저 API를 사용하는 빌드 아티팩트는 `browsers` 필드 하위에 포함되도록 변경되었습니다. 마찬가지로 여기서 브레이킹
체인지가 발생했는데, 기존 `main`, `module` 필드가 가르키는 아티팩트들에서는 브라우저 API를 사용하지 않는 버전으로
변경되었습니다.

rollup의 `plugin-node-resolve`는 기본값으로 `exports` 필드를 확인할 때, `default`,
`module`, `import` 3가지의 조건 필드만을 확인합니다. 여기에 `browser` 필드가 없으므로, 번들 시 브라우저
API를 사용하지 않는 버전의 react-textarea-autosize가 포함되게 됩니다.

플러그인의 `browser` 속성을 `true` 로 변경하여 모듈 해석 시 `browser` 필드(`exports.brower`,
`browser`)도 참고하도록 변경합니다.

> If true, instructs the plugin to use the browser module resolutions in
package.json and adds 'browser' to exportConditions if it is not present
so browser conditionals in exports are applied.

### Breaking change? (Yes/No)
<!-- If Yes, please describe the impact and migration path for users -->

No

## References
<!-- Please list any other resources or points the reviewer should be
aware of -->

- #1609 
- https://www.npmjs.com/package/@rollup/plugin-node-resolve
- https://nodejs.org/api/packages.html#community-conditions-definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore:deps Issue or PR related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants