Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify styles globally #1975

Merged
merged 32 commits into from
Feb 7, 2024
Merged

Modify styles globally #1975

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
8a858f6
fix(form-control): fix form label specify issue
sungik-choi Feb 4, 2024
e646ed3
feat: rm all:unset styles inside components
sungik-choi Feb 4, 2024
ab8a562
fix(checkbox): fix checkbox indicator cursor pointer style
sungik-choi Feb 4, 2024
4ad3dd7
fix(avatar): fix bordered style issue
sungik-choi Feb 4, 2024
ad6d74d
feat(styles): ensure all elements that have padding or border styles …
sungik-choi Feb 4, 2024
536ef1a
refactor(box): rm duplicated box-sizing
sungik-choi Feb 4, 2024
6e48ba6
feat(styles): apply default focus ring style & style elements with th…
sungik-choi Feb 5, 2024
2601d0f
refactor(modal): change data prop name
sungik-choi Feb 5, 2024
20e8535
fix(spinner): fix shorthand style issue (inherit keyword)
sungik-choi Feb 5, 2024
f2771d5
fix(legacy-stack-item): fix shorthand style issue (inherit keyword)
sungik-choi Feb 5, 2024
9d2192f
feat(styles): add custom css reset
sungik-choi Feb 5, 2024
cad4088
feat(app-provider): add preflight prop
sungik-choi Feb 5, 2024
be7eb21
test(app-provider): add unit tests
sungik-choi Feb 5, 2024
65ea3c8
feat: implement unstyled button component
sungik-choi Feb 6, 2024
6974f7a
feat: apply UnstyledButton component & remove duplicated cursor: poin…
sungik-choi Feb 6, 2024
53415fc
fix(banner): fix styling issue with anchor tag with link
sungik-choi Feb 6, 2024
ce093c3
feat(tag): make delete icon to keyboard focusable
sungik-choi Feb 6, 2024
bc23a1f
test(unstyled-button): add unit test
sungik-choi Feb 6, 2024
fc76ca2
test: update snapshot
sungik-choi Feb 6, 2024
d4e384a
fix: rm deadcode
sungik-choi Feb 6, 2024
f050776
feat(styles): rm reset layer of entire system
sungik-choi Feb 6, 2024
48ec582
Merge branch 'alpha' into feat/refine-styles
sungik-choi Feb 6, 2024
203b541
style: indent
sungik-choi Feb 6, 2024
738dd28
feat: move focus ring style from global to UnstyledButton
sungik-choi Feb 6, 2024
f269eb8
feat(base-button): rename to BaseButton
sungik-choi Feb 6, 2024
24e2220
refactor(button): rm duplicated outline stlye
sungik-choi Feb 6, 2024
3db0221
docs(base-button): add jsdoc
sungik-choi Feb 6, 2024
92b7ecb
feat: rm duplicated placeholder style
sungik-choi Feb 6, 2024
ca34c2d
fix(text-area): reset user agent font style
sungik-choi Feb 6, 2024
fe55ccd
feat(styles): add outline style to none button component style
sungik-choi Feb 6, 2024
f529c15
Merge branch 'alpha' into feat/refine-styles
sungik-choi Feb 7, 2024
8ad024c
refactor: inline variable
sungik-choi Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/bezier-react/src/components/FormControl/FormControl.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
}

.FormLabelWrapper {
&:where(.position-top) {
&.position-top {
Copy link
Collaborator

@yangwooseong yangwooseong Feb 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존에 where 를 사용한 것 때문에 스타일링에 이슈가 있었나요? 스토리북에서 position 을 바꾸면 잘 적용되는 것처럼 보여서 궁금해서 질문드립니다! (#1981 기준 스토리북)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AS-IS TO-BE
image image

labelPosition=left 인 케이스에서 오버라이드가 안되는 문제가 있었어요.

margin-bottom: 4px;
padding: 0 2px;
}

&:where(.position-left) {
&.position-left {
display: flex;
grid-column: 1 / 1;
grid-row: 1 / 1;
Expand All @@ -29,7 +29,7 @@
margin-top: 4px;
padding: 0 2px;

&:where(.position-left) {
&.position-left {
grid-column: 2;
grid-row: 2 / 2;
}
Expand Down