Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Stylelint bezier #2102

Closed
wants to merge 2 commits into from
Closed

[WIP] Stylelint bezier #2102

wants to merge 2 commits into from

Conversation

sungik-choi
Copy link
Contributor

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

Details

Breaking change? (Yes/No)

References

@sungik-choi sungik-choi added the feat Issue or PR related to a new feature label Mar 22, 2024
@sungik-choi sungik-choi self-assigned this Mar 22, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4c03c56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sungik-choi sungik-choi changed the base branch from alpha to main March 26, 2024 08:37
@sungik-choi
Copy link
Contributor Author

우선순위 변경으로 이 PR은 우선 닫고, 이후에 다시 살펴보도록

@channeltalk ChannelTalk
Copy link

channeltalk bot commented Jun 21, 2024

https://desk.channel.io/#/channels/1/team_chats/groups/1237/66750896ec9a5be1a715

@channeltalk ChannelTalk
Copy link

channeltalk bot commented Jun 21, 2024

https://desk.channel.io/#/channels/1/team_chats/groups/1237/66750896eb6c17266c18

@yangwooseong yangwooseong mentioned this pull request Aug 8, 2024
Merged
6 tasks
yangwooseong added a commit that referenced this pull request Aug 21, 2024
@yangwooseong @sungik-choi
Implement stylelint-bezier package for easy use of bezier design to…
5c5a10c 
…ken (#2412)

<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [ ] I wrote or updated **documentation** related to the changes. (or
didn't have to) **(TODO)**
- [ ] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue

<!-- Please link to issue if one exists -->

<!-- Fixes #0000 -->

- resolves #1996 

## Summary

<!-- Please brief explanation of the changes made -->

- bezier-tokens에 있는 토큰이외의 css variable을 사용했을 때 에러나 워닝을 보여주는 stylelint
config 패키지를 추가합니다.

## Details

<!-- Please elaborate description of the changes -->

- 공식 문서에는 plugin을 만들 때 export default createPlugin(...) 이런 식으로 소개하고 있는데
막상 해보면 vscode stylelint extension 에서 에러가 나는 등 문제가 있어서 polaris 코드를 참고해서
만들었습니다. 추측컨대 vscode-stylelint 쪽에서 [v16 지원을 하고 있지
않아서](stylelint/vscode-stylelint#540) stylelint
최신 문법과 호환이 안되고 있어서 발생하는 문제로 보입니다.
- V2 token (e.g. `--alpha-color-fg-black-darkest`) 까지 사용가능하게 했습니다. 
- styled-components와 scss 모두 대응이 가능합니다. styled-components는 customSyntax를
postcss-styled-syntax로 지정해서 .ts, .tsx 파일을 오버라이드했습니다.
- 테스트 코드를 작성하고 싶었으나 외부 모듈을 읽고 있어서 작성하기가 까다로워서 생략했습니다. 
- 버저닝 관리를 어떻게 해야할지는 고민입니다. bezier-token 버전이 올라갈 때마다 bezier-react 버전과
stylelint-bezier 버전이 올라가야 하고(이건 changeset이 해줌), 만약 bezier-token 에서 토큰
이름이 바뀌거나 없어진다면 bezier-react 의 peerDeps 에 있는 stylelint-bezier 버전까지
올려야합니다. 제 생각에는 peerDeps에 있는 버전을 관리하는 것은 어쩔 수 없이 수동으로 해야할 것 같은데, 혹시 다른
아이디어 있다면 부탁드립니다..! @sungik-choi


https://github.com/user-attachments/assets/1b94c6ed-e91f-444d-a8ad-e56a7e6efa79


### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->

- No

## References

<!-- Please list any other resources or points the reviewer should be
aware of -->

- #2102
- https://stylelint.io/awesome-stylelint#custom-syntaxes

---------

Co-authored-by: Ed Sungik Choi <sungik.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangwooseong yangwooseong Awaiting requested review from yangwooseong yangwooseong will be requested when the pull request is marked ready for review yangwooseong is a code owner

Assignees

@sungik-choi sungik-choi

Labels
feat Issue or PR related to a new feature
Projects
No open projects
Bezier React
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sungik-choi