feat: filter carry over behavior #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemonkey800
changed the title
kne42
reviewed
Sep 11, 2024
| setSearchParams( | ||
| (prev) => { | ||
| Object.values(QueryParams).forEach((param) => prev.delete(param)) | ||
| prev.delete('page') |
There was a problem hiding this comment.
wouldn't this already be covered since QueryParams.Page would be deleted by the above line?
There was a problem hiding this comment.
@kne42 I would think so, it looks like this got added here: https://github.com/chanzuckerberg/cryoet-data-portal/pull/313/files#diff-414198be074a48a27b5b082c21dd793a3f886ef1e34e5ebec6183b016c201978R85
do you remember why? 🤔
There was a problem hiding this comment.
probably didn't realize it was included in QueryParams
yee let me take a look 🫡 |
kne42
approved these changes
Sep 11, 2024
bchu1
reviewed
Sep 12, 2024
bchu1
reviewed
Sep 12, 2024
bchu1
approved these changes
Sep 12, 2024
codemonkey800
force-pushed
the
jeremy/deposition-filter-carryover
branch
from
01d658b
to
4e25439
Compare
github-actions bot
added a commit
that referenced
this pull request
Sep 16, 2024
🤖 I have created a release *beep* *boop* --- ## [1.28.0](web-v1.27.0...web-v1.28.0) (2024-09-16) ### ✨ Features * Descriptions of datasets and depositions. ([#1134](#1134)) ([6f2d66f](6f2d66f)) * filter carry over behavior ([#1128](#1128)) ([afd3497](afd3497)) * Prep FE codebase for 2 API URLs ([#1126](#1126)) ([e76f270](e76f270)) ### 🐞 Bug Fixes * Fix not enough padding below key photos ([#1140](#1140)) ([6e84e51](6e84e51)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kne42
added a commit
that referenced
this pull request
Sep 16, 2024
* main: chore(main): release web 1.28.0 (#1137) fix: Fix not enough padding below key photos (#1140) feat: filter carry over behavior (#1128) feat: Prep FE codebase for 2 API URLs (#1126) docs: Add graphics to data organization page (#1135) feat: Descriptions of datasets and depositions. (#1134) chore(main): release web 1.27.0 (#1127)
kne42
added a commit
that referenced
this pull request
Sep 21, 2024
* main: (24 commits) feat: Add more V2 API fields (#1166) feat: Stop querying publications in V2 temporarily (#1160) feat: Add reference tomogram selector for single annotation download (#1136) feat: Add alignment ID row + tooltip (#1153) feat: upgrade sds colors (#1078) feat: upgrade sds (#1077) chore(main): release web 1.29.0 (#1152) feat: Change download all annotations copy (#1151) feat: Start writing run query for new API (#1149) ci: remove glob path pattern for python client tests workflow (#1143) chore(main): release web 1.28.0 (#1137) fix: Fix not enough padding below key photos (#1140) feat: filter carry over behavior (#1128) feat: Prep FE codebase for 2 API URLs (#1126) docs: Add graphics to data organization page (#1135) feat: Descriptions of datasets and depositions. (#1134) chore(main): release web 1.27.0 (#1127) feat: integrate depositions backend (#1093) docs: Implement SDS colors for dark mode (#1131) feat: Implement new single tomogram download flow (#1120) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#527
#1081
#1118
Demo
https://dev-filter-carry.cryoet.dev.si.czi.technology/