Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Descriptions of datasets and depositions. #1134

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

ehoops-cz
Copy link
Contributor

@ehoops-cz ehoops-cz commented Sep 12, 2024

Related issue #919

Adds a description for datasets and depositions.
Updates the section title from “Deposition Data” to “Datasets with Deposition Data”.

Screenshot 2024-09-12 at 4 31 54 PM Screenshot 2024-09-12 at 4 31 15 PM Screenshot 2024-09-12 at 4 32 57 PM

@Janeece
Copy link
Collaborator

Janeece commented Sep 12, 2024

@ehoops-cz on the single deposition page, the "datasets with deposition data" table header doesnt need the gray background, could you remove it for just that one?

@kandarpksk
Copy link
Collaborator

Please add "Learn more" text (no full stop at the end) to each of the descriptions, with links as noted below:

Link for datasets:
https://chanzuckerberg.github.io/cryoet-data-portal/cryoet_data_portal_docsite_data.html#datasets

Link for depositions:
https://chanzuckerberg.github.io/cryoet-data-portal/cryoet_data_portal_docsite_data.html#depositions

@ehoops-cz
Copy link
Contributor Author

Please add "Learn more" text (no full stop at the end) to each of the descriptions, with links as noted below:

Link for datasets: https://chanzuckerberg.github.io/cryoet-data-portal/cryoet_data_portal_docsite_data.html#datasets

Link for depositions: https://chanzuckerberg.github.io/cryoet-data-portal/cryoet_data_portal_docsite_data.html#depositions

Thank you! I meant to come back to those, but forgot

Add Learn More links

Only show gray background on datasets and depositions pages.
@ehoops-cz ehoops-cz merged commit 6f2d66f into main Sep 13, 2024
13 checks passed
@ehoops-cz ehoops-cz deleted the descriptions branch September 13, 2024 18:30
github-actions bot added a commit that referenced this pull request Sep 16, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.28.0](web-v1.27.0...web-v1.28.0)
(2024-09-16)


### ✨ Features

* Descriptions of datasets and depositions.
([#1134](#1134))
([6f2d66f](6f2d66f))
* filter carry over behavior
([#1128](#1128))
([afd3497](afd3497))
* Prep FE codebase for 2 API URLs
([#1126](#1126))
([e76f270](e76f270))


### 🐞 Bug Fixes

* Fix not enough padding below key photos
([#1140](#1140))
([6e84e51](6e84e51))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kne42 added a commit that referenced this pull request Sep 16, 2024
* main:
  chore(main): release web 1.28.0 (#1137)
  fix: Fix not enough padding below key photos (#1140)
  feat: filter carry over behavior (#1128)
  feat: Prep FE codebase for 2 API URLs (#1126)
  docs: Add graphics to data organization page (#1135)
  feat: Descriptions of datasets and depositions. (#1134)
  chore(main): release web 1.27.0 (#1127)
kne42 added a commit that referenced this pull request Sep 21, 2024
* main: (24 commits)
  feat: Add more V2 API fields (#1166)
  feat: Stop querying publications in V2 temporarily (#1160)
  feat: Add reference tomogram selector for single annotation download (#1136)
  feat: Add alignment ID row + tooltip (#1153)
  feat: upgrade sds colors (#1078)
  feat: upgrade sds (#1077)
  chore(main): release web 1.29.0 (#1152)
  feat: Change download all annotations copy (#1151)
  feat: Start writing run query for new API (#1149)
  ci: remove glob path pattern for python client tests workflow (#1143)
  chore(main): release web 1.28.0 (#1137)
  fix: Fix not enough padding below key photos (#1140)
  feat: filter carry over behavior (#1128)
  feat: Prep FE codebase for 2 API URLs (#1126)
  docs: Add graphics to data organization page (#1135)
  feat: Descriptions of datasets and depositions. (#1134)
  chore(main): release web 1.27.0 (#1127)
  feat: integrate depositions backend (#1093)
  docs: Implement SDS colors for dark mode (#1131)
  feat: Implement new single tomogram download flow (#1120)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants