Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort tiltseries quality filter scores #1296

Conversation

daniel-ji
Copy link
Contributor

@daniel-ji daniel-ji commented Nov 1, 2024

Resolves #1263. Orders from highest score (5) to lowest (1).

Copy link
Contributor

@codemonkey800 codemonkey800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOOOO @daniel-ji so good to see you, thank you for the contribution 🫶

@daniel-ji daniel-ji changed the title sort tiltseries quality filter scores fix: sort tiltseries quality filter scores Nov 4, 2024
@daniel-ji
Copy link
Contributor Author

of course! good to see you and hope everything's going well!

@codemonkey800
Copy link
Contributor

hmm the E2Es are throwing an error I think because it's a fork, I don't think I accounted for that when I built the workflow. let me merge both and I'll monitor the E2E tests for staging haha

@codemonkey800 codemonkey800 merged commit aa2b28f into chanzuckerberg:main Nov 4, 2024
4 of 6 checks passed
@junxini
Copy link
Contributor

junxini commented Nov 4, 2024

@daniel-ji the real GOAT!!!! thank you thank you!

github-actions bot added a commit that referenced this pull request Nov 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.35.1](web-v1.35.0...web-v1.35.1)
(2024-11-05)


### 🐞 Bug Fixes

* header dropdown misplacement on icon click
([#1297](#1297))
([8ecb914](8ecb914))
* sort tiltseries quality filter scores
([#1296](#1296))
([aa2b28f](aa2b28f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scores in Tilt Series Quality filter are unsorted
3 participants