Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header dropdown misplacement on icon click #1297

Merged

Conversation

daniel-ji
Copy link
Contributor

Resolves #1247.

Dropdown misplacement would occur when the Icon itself was clicked, not the text, resulting in a bad anchor element.

@daniel-ji daniel-ji changed the title fix header dropdown misplacement on icon click fix: header dropdown misplacement on icon click Nov 4, 2024
Copy link
Contributor

@codemonkey800 codemonkey800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yooo didn't even realize you had 2 PRs, thank you so much

@codemonkey800 codemonkey800 merged commit 8ecb914 into chanzuckerberg:main Nov 4, 2024
5 of 6 checks passed
github-actions bot added a commit that referenced this pull request Nov 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.35.1](web-v1.35.0...web-v1.35.1)
(2024-11-05)


### 🐞 Bug Fixes

* header dropdown misplacement on icon click
([#1297](#1297))
([8ecb914](8ecb914))
* sort tiltseries quality filter scores
([#1296](#1296))
([aa2b28f](aa2b28f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header dropdown sometimes appears on the other side of the screen
2 participants