-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Tomograms #624
Comments
#624 Adds basic tabs functionality (UX not final). Currently the Tomograms tab just shows the Annotations table with no filters. Next: Add initial Tomograms table. https://github.com/user-attachments/assets/cb54c5b1-e4a3-40a4-a4ac-40f072a06e11
BE things needed from the final UX mocks:
|
@junxini Do we have a decision on the |
@bchu1 This document spec should address most of the fields specified in your comment. I will add the ones it doesn't address below:
This is currently sourced from The python code snippets will be shared out once that has been finalized. |
The remaining work is all related to the API migration #1101
Here's the final copy spreadsheet: https://docs.google.com/spreadsheets/d/1QEPiDcjGJYWSZXsbRjwHd9aeZjbk_tvv2UQ4DKyMwxk/edit?gid=1179230519#gid=1179230519 Here's a PR I started for migrating the annotations field to V2: #1190 Here's the updated mocks for the download flow now that we're not supporting annotation transformation: https://www.figma.com/design/RsjklVi95DFKatU4Uzi2OG/Janeece---Multiple-Tomograms?node-id=1358-15181&node-type=text&m=dev |
Note: |
@codemonkey800 Here are the prioritized design review comments doc: https://docs.google.com/document/d/1NpMvWUqCvGowvl9MxZP0XlL2qBJBvyB_OJVHl3jqEjE/edit?usp=sharing Overall this is looking so good (yay @bchu1!), very few P0 comments. If I called out anything that is blocked by the items Bryan listed above, isnt technically feasible, or was previously deprioritized just leave a comment in the doc so I can note it in the designs. |
Follow up of #1190 to complete the remaining integration items from #624 (comment) This does not fully migrate the run query to use API v2, it only uses some of the data for MT related features (`isPortalStandard`, `isAuthorSubmitted`, etc.) --------- Co-authored-by: Bryan Chu <bchu@chanzuckerberg.com>
Addresses design feedback from #624 (comment) ## Demo https://dev-on.cryoet.dev.si.czi.technology/
The following should be built behind a feature flag
Link to CTF/Alignment/Multiple Tomogram updates to API and client: https://docs.google.com/document/d/1InjJKrx78Sv44QguMXR0p1o9Y34oPnMOY9J3aj375ks/edit#heading=h.eoh3rqmh58k2
The content below can get started while design is WIP:
After design handoff is completed:
API migration:
TODO(bchu): Make other download flow tickets
Punted (low priority, high effort):
The text was updated successfully, but these errors were encountered: