Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Tomograms #624

Open
17 of 19 tasks
junxini opened this issue Apr 4, 2024 · 7 comments
Open
17 of 19 tasks

Multiple Tomograms #624

junxini opened this issue Apr 4, 2024 · 7 comments
Assignees
Labels
epic high level grouping of issues

Comments

@junxini junxini added the epic high level grouping of issues label Apr 4, 2024
@manasaV3 manasaV3 changed the title Multiple Tomograms Epic Multiple Tomograms Jul 22, 2024
@bchu1 bchu1 self-assigned this Jul 29, 2024
@bchu1 bchu1 added this to the Sprint Interim between H1-> H2 milestone Jul 29, 2024
bchu1 added a commit that referenced this issue Aug 2, 2024
#624 

Adds basic tabs functionality (UX not final).

Currently the Tomograms tab just shows the Annotations table with no
filters.

Next: Add initial Tomograms table.



https://github.com/user-attachments/assets/cb54c5b1-e4a3-40a4-a4ac-40f072a06e11
@manasaV3 manasaV3 assigned bchu1 and unassigned bchu1 Aug 8, 2024
@junxini junxini removed this from the Sprint Interim between H1-> H2 milestone Aug 23, 2024
@bchu1
Copy link
Contributor

bchu1 commented Aug 30, 2024

BE things needed from the final UX mocks:

  1. run.frames
  2. run.alignments
  3. alignment.defocus_value
  4. alignment.is_canonical
  5. alignment.alignment_type
  6. alignment.volume_{x|y|z}_dimension
  7. alignment.volume_{x|y|z}_offset
  8. alignment.rotation
  9. alignment.tilt_offset
  10. alignment.affine_transformation_matrix
  11. tomogram.alignment
  12. tomogram.is_portal_standard
  13. tomogram.is_author_submitted
  14. tomogram.is_viz_default
  15. tomogram.related_database_entries
  16. tomogram.publications
  17. annotation_file.alignment
  18. Download transformed annotation Portal CLI code snippet
  19. Download transformed annotation Python API code snippet
  20. New S3 directory structure for downloading all annotations of a run (or where the new s3_prefix will live if that's possible)
  21. New download all annotations Python API code snippet

@manasaV3
Copy link
Contributor

@junxini Do we have a decision on the defocus_value being a P1 feature for the backend?

@manasaV3
Copy link
Contributor

@bchu1 This document spec should address most of the fields specified in your comment. I will add the ones it doesn't address below:

  1. run.frames

This is currently sourced from tiltseries.frame_count this can continue to be sourced from there

The python code snippets will be shared out once that has been finalized.

@junxini
Copy link
Contributor Author

junxini commented Sep 1, 2024

@junxini Do we have a decision on the defocus_value being a P1 feature for the backend?

@uermel could you confirm if this is dependent on frames being imported? If so, frames likely won't get in until early Q4

@bchu1
Copy link
Contributor

bchu1 commented Sep 30, 2024

@codemonkey800

The remaining work is all related to the API migration #1101

Here's the final copy spreadsheet: https://docs.google.com/spreadsheets/d/1QEPiDcjGJYWSZXsbRjwHd9aeZjbk_tvv2UQ4DKyMwxk/edit?gid=1179230519#gid=1179230519

Here's a PR I started for migrating the annotations field to V2: #1190

Here's the updated mocks for the download flow now that we're not supporting annotation transformation: https://www.figma.com/design/RsjklVi95DFKatU4Uzi2OG/Janeece---Multiple-Tomograms?node-id=1358-15181&node-type=text&m=dev

@bchu1
Copy link
Contributor

bchu1 commented Oct 1, 2024

Note: tomogram.is_canonical in V1 for the intents and purposes of the launch is tomogram.isAuthorSubmitted in V2.

@Janeece
Copy link
Collaborator

Janeece commented Oct 4, 2024

@codemonkey800 Here are the prioritized design review comments doc: https://docs.google.com/document/d/1NpMvWUqCvGowvl9MxZP0XlL2qBJBvyB_OJVHl3jqEjE/edit?usp=sharing

Overall this is looking so good (yay @bchu1!), very few P0 comments. If I called out anything that is blocked by the items Bryan listed above, isnt technically feasible, or was previously deprioritized just leave a comment in the doc so I can note it in the designs.

codemonkey800 added a commit that referenced this issue Oct 16, 2024
Follow up of #1190 to complete the remaining integration items from
#624 (comment)

This does not fully migrate the run query to use API v2, it only uses
some of the data for MT related features (`isPortalStandard`,
`isAuthorSubmitted`, etc.)

---------

Co-authored-by: Bryan Chu <bchu@chanzuckerberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic high level grouping of issues
Projects
None yet
Development

No branches or pull requests

4 participants