Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Undo changes for transforming annotations and add new callout for mismatched alignments #1191

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

bchu1
Copy link
Contributor

@bchu1 bchu1 commented Sep 27, 2024

#1046

Transforming annotations is now out of scope.

Alignment of annotation has not been integrated with the BE yet, since that requires migrating the entire annotations query.

image image

@bchu1 bchu1 changed the title feat: Undo changes for transforming annotations feat: Undo changes for transforming annotations and add new callout for mismatched alignments Sep 30, 2024
Copy link
Collaborator

@Janeece Janeece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchu1 Callout looks good.

The annotation alignment ID is missing from the top metadata area on both step 1 and step 2 — is this unable to be displayed yet?
Screenshot 2024-09-30 at 4 42 12 PM
Screenshot 2024-09-30 at 4 42 02 PM

@bchu1
Copy link
Contributor Author

bchu1 commented Oct 1, 2024

@bchu1 Callout looks good.

The annotation alignment ID is missing from the top metadata area on both step 1 and step 2 — is this unable to be displayed yet? Screenshot 2024-09-30 at 4 42 12 PM Screenshot 2024-09-30 at 4 42 02 PM

Correct, this requires quite a bit of migration work before we can show that.

@bchu1 bchu1 merged commit ea1598d into main Oct 1, 2024
13 checks passed
@bchu1 bchu1 deleted the bchu/undo branch October 1, 2024 19:23
github-actions bot added a commit that referenced this pull request Oct 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.31.0](web-v1.30.0...web-v1.31.0)
(2024-10-03)


### ✨ Features

* Add portal standard badge to tomograms table and integrate alignment
metadata accordion with new API
([#1179](#1179))
([1de70a1](1de70a1))
* Add standard tomogram badge to tomogram selector
([#1181](#1181))
([ac4ad27](ac4ad27))
* Add tooltip to Alignment ID field in tomogram sidebar
([#1196](#1196))
([fad5207](fad5207))
* Integrate more V2 API queries
([#1174](#1174))
([92f80a7](92f80a7))
* Migrate and start using tomograms query in UI
([#1169](#1169))
([d21ffd9](d21ffd9))
* Undo changes for transforming annotations and add new callout for
mismatched alignments
([#1191](#1191))
([ea1598d](ea1598d))
* update annotation row name
([#1163](#1163))
([6164201](6164201))
* Update to generic annotation transformation callout during download
([#1186](#1186))
([5597524](5597524))


### 🐞 Bug Fixes

* address misc UI/UX bugs
([#1192](#1192))
([178737d](178737d))
* change incorrect deposition links
([#1133](#1133))
([dc642e5](dc642e5))
* Stop querying depositionTitle
([#1187](#1187))
([07a08d4](07a08d4))


### 🧹 Miscellaneous Chores

* prefix IDs across the portal
([#1178](#1178))
([1732fb2](1732fb2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants