Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update go lint #665

Merged
merged 5 commits into from
Oct 24, 2024
Merged

feat: update go lint #665

merged 5 commits into from
Oct 24, 2024

Conversation

naihsuanshao
Copy link
Contributor

@naihsuanshao naihsuanshao commented Oct 24, 2024

Summary

This change is for updating linter in this repo. James' PR has been failing on this issue, so we're upgrading the go lint package to the latest and to used our self-hosted runner.

Test Plan

As long as all check pass, it should be fine.

References

Argus Lint yaml

@naihsuanshao naihsuanshao requested a review from a team as a code owner October 24, 2024 16:59
@naihsuanshao naihsuanshao requested review from jjb007 and hspitzley-czi and removed request for alldoami October 24, 2024 17:38
@jjb007
Copy link
Contributor

jjb007 commented Oct 24, 2024

Thanks, @naihsuanshao ! I'll defer to the pros for reviewing this one.

@naihsuanshao naihsuanshao merged commit eb4a894 into main Oct 24, 2024
109 checks passed
@naihsuanshao naihsuanshao deleted the nshao/oncall-update-go-lint branch October 24, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants