Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade package react-helmet to react-helmet-async #48

Closed
bkmartinjr opened this issue Apr 16, 2022 · 0 comments · Fixed by #79
Closed

Upgrade package react-helmet to react-helmet-async #48

bkmartinjr opened this issue Apr 16, 2022 · 0 comments · Fixed by #79
Assignees
@bkmartinjr
Milestone
0.2.0

Comments

@bkmartinjr
Copy link
Contributor

bkmartinjr commented Apr 16, 2022 •
edited
Loading

react-helmet is unmaintained and no longer compatible with recent React versions. There is a fork react-helmet-async which should be used instead.

This change will resolve the startup error message seen in the console:

Warning: Using UNSAFE_componentWillMount in strict mode is not recommended and may indicate bugs in your code. See https://reactjs.org/link/unsafe-component-lifecycles for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.

Please update the following components: SideEffect(NullComponent)

For more details, see:
@bkmartinjr bkmartinjr self-assigned this Apr 17, 2022
@bkmartinjr bkmartinjr added this to the 0.2.0 milestone Apr 22, 2022
@bkmartinjr bkmartinjr mentioned this issue Apr 28, 2022
Merged
@bkmartinjr bkmartinjr moved this to In Progress in OntologyUI Apr 28, 2022
Repository owner moved this from In Progress to Done in OntologyUI Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkmartinjr bkmartinjr

Labels
None yet
Projects
OntologyUI
Status: Done
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

port from react-helmet to react-helmet-async chanzuckerberg/ontology-ui
1 participant
@bkmartinjr