dependency of react-helmet uses legacy componentWillMount lifecycle method #413

jfrolich · 2018-11-11T16:28:54Z

The dependency react-side-effect uses componentWillMount, so react-helmet will not work in concurrentMode.

jfrolich · 2018-11-11T16:29:55Z

gaearon/react-side-effect#54

danielweck · 2019-08-16T07:15:42Z

Looks like react-helmet-async is a useful alternative:
https://github.com/staylor/react-helmet-async

goldmont · 2019-08-31T19:23:52Z

Looks like react-side-effect v2.0.0 now uses UNSAFE_componentWillMount.

Thus, no more warnings in the console.

eduard-malakhov · 2019-09-01T07:47:32Z

I confirm, after manually upgrading react-side-effect to v2.0.0, the warning is gone.

kevr · 2019-12-03T05:32:41Z

Looks like react-helmet-async is a useful alternative:
https://github.com/staylor/react-helmet-async

No, it's not. Creating another package just to undeprecate something so trivial is not an alternative, it's a cop out.

samuraime · 2019-12-30T15:59:38Z

before react-helmet update its dependency, a temporary workaround in package.json

  "resolutions": {
    "react-side-effect": "^2.1.0"
  }

cwelch5 · 2020-01-27T18:31:13Z

Thanks for everyone's patience. We are actively working on 6.0.0 release. 6.0.0-beta.2 is available and will work with the latest React version.

This dep was previously resolving to a version which was actively using a deprecated lifecycle method and causing noise in the build/test log. The makers of the react-helmet library (which uses the dep), are working on a new release to overcome this: nfl/react-helmet#413 (comment). We'll pick this up with dependabot once it's out of beta.

This dep was previously resolving to a version which was actively using a deprecated lifecycle method and causing noise in the build/test log. The makers of the react-helmet library (which uses the dep), are working on a new release to overcome this: nfl/react-helmet#413 (comment). We'll pick this up with dependabot once it's out of beta. Co-authored-by: Sonya Moisset <sonya.moisset@gmail.com>

dantman · 2020-02-10T12:25:05Z

so react-helmet will not work in concurrentMode

It doesn't sound like the issue as originally opened was actually fixed. The only difference is a switch from componentWillMount (which emits a depreciation notice and won't work in concurrent mode) was replaced with UNSAFE_componentWillMount (that doesn't emit a deprecation notice; but still does not work in concurrent mode).

* upgrades to antd to v4 * upgrades to react@16.13.10 * upgrades to react-router to v5 Unresolved: * `componentWillReceiveProps` warnings from `react-vis` uber/react-vis#1253 * search name space truncates some options like `conferen...` ant-design/ant-design#21754 * `componentWillMount` warnings from `react-helmet` nfl/react-helmet#413 * `componentWillMount` warnings from `react-loadable` jamiebuilds/react-loadable#220 * `Cannot update a component from inside the function body of a different component.` worning from `antd` ant-design/ant-design#21800

INSPIR-3203 * upgrades to antd to v4 * upgrades to react@16.13.10 * upgrades to react-router to v5 Unresolved: * `componentWillReceiveProps` warnings from `react-vis` uber/react-vis#1253 * search name space truncates some options like `conferen...` ant-design/ant-design#21754 * `componentWillMount` warnings from `react-helmet` nfl/react-helmet#413 * `componentWillMount` warnings from `react-loadable` jamiebuilds/react-loadable#220 * `Cannot update a component from inside the function body of a different component.` worning from `antd` ant-design/ant-design#21800

* upgrades to antd to v4 * fixes UX problems with date range picker: INSPIR-3203 * reduces bundle size by removing unnecessary icons: INSPIR-3228 * upgrades to react@16.13.10 * upgrades to react-router to v5 Unresolved: * `componentWillReceiveProps` warnings from `react-vis` uber/react-vis#1253 * search name space truncates some options like `conferen...` ant-design/ant-design#21754 * `componentWillMount` warnings from `react-helmet` nfl/react-helmet#413 * `componentWillMount` warnings from `react-loadable` jamiebuilds/react-loadable#220 * `Cannot update a component from inside the function body of a different component.` worning from `antd` ant-design/ant-design#21800

* upgrades to antd to v4 * fixes UX problems with date range picker: INSPIR-3203 * reduces bundle size by removing unnecessary icons: INSPIR-3228 * upgrades to react@16.13.10 * upgrades to react-router to v5 Unresolved: * `componentWillReceiveProps` warnings from `react-vis` uber/react-vis#1253 * search name space truncates some options like `conferen...` ant-design/ant-design#21754 * `componentWillMount` warnings from `react-helmet` nfl/react-helmet#413 * `componentWillMount` warnings from `react-loadable` jamiebuilds/react-loadable#220 * `Cannot update a component from inside the function body of a different component.` worning from `antd` ant-design/ant-design#21800 * `componentWillReceiveProps` warnings from `react-quill` zenoamaro/react-quill#549

miquelvir · 2021-01-01T13:37:20Z

Why is this closed? Seems that still not working properly (bbc/simorgh#3893 (comment)) since we are getting the warning with ^6.1.0.

adamnorbacker · 2021-04-07T10:14:55Z

@cwelch5 its still the same issue.

tmbtech added bug enhancement help wanted labels Nov 16, 2018

This was referenced Aug 16, 2019

Throws warnings in React 16.9 and will not work with React 17 #465

Closed

Deprecated React componentWillMount in external package dependency react-helmet edrlab/thorium-reader#596

Closed

rifaidev mentioned this issue Sep 15, 2019

Fix compatibility with React 16.9 #472

Closed

dr3 mentioned this issue Sep 23, 2019

componentWillMount warning from SideEffect(NullComponent) bbc/simorgh#3893

Closed

1 task

lannonbr mentioned this issue Sep 25, 2019

Nested dependency calling soon to be deprecated componentWillMount method gatsbyjs/gatsby#17865

Closed

cwelch5 closed this as completed Jan 27, 2020

egmcdonald mentioned this issue Jan 28, 2020

WEBREF-49 📦 Resolved react-side-effect dependency PrideInLondon/pride-london-web#1297

Merged

bkmartinjr mentioned this issue Apr 16, 2022

Upgrade package react-helmet to react-helmet-async chanzuckerberg/ontology-ui#48

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dependency of react-helmet uses legacy componentWillMount lifecycle method #413

dependency of react-helmet uses legacy componentWillMount lifecycle method #413

jfrolich commented Nov 11, 2018

jfrolich commented Nov 11, 2018

danielweck commented Aug 16, 2019

goldmont commented Aug 31, 2019 •

edited

Loading

eduard-malakhov commented Sep 1, 2019

kevr commented Dec 3, 2019 •

edited

Loading

samuraime commented Dec 30, 2019

cwelch5 commented Jan 27, 2020

dantman commented Feb 10, 2020

miquelvir commented Jan 1, 2021

adamnorbacker commented Apr 7, 2021

dependency of react-helmet uses legacy componentWillMount lifecycle method #413

dependency of react-helmet uses legacy componentWillMount lifecycle method #413

Comments

jfrolich commented Nov 11, 2018

jfrolich commented Nov 11, 2018

danielweck commented Aug 16, 2019

goldmont commented Aug 31, 2019 • edited Loading

eduard-malakhov commented Sep 1, 2019

kevr commented Dec 3, 2019 • edited Loading

samuraime commented Dec 30, 2019

cwelch5 commented Jan 27, 2020

dantman commented Feb 10, 2020

miquelvir commented Jan 1, 2021

adamnorbacker commented Apr 7, 2021

goldmont commented Aug 31, 2019 •

edited

Loading

kevr commented Dec 3, 2019 •

edited

Loading