Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Overload lax methods #58

Merged
merged 18 commits into from
Nov 10, 2024
Merged

[feat] Overload lax methods #58

merged 18 commits into from
Nov 10, 2024

Conversation

Routhleck
Copy link
Collaborator

@Routhleck Routhleck commented Nov 8, 2024

  • accept unitless
  • array creation
  • change unit
  • control flow
  • keep unit
  • linear algorithm
  • parallel
  • remove unit
  • misc
  • docstrings
    • accept unitless
    • array creation
    • change unit
    • keep unit
    • linear algorithm
    • remove unit
    • misc

@Routhleck Routhleck changed the title [feat] Compatible with lax methods [feat] Overload lax methods Nov 9, 2024
@Routhleck Routhleck marked this pull request as ready for review November 10, 2024 05:22
@@ -31,6 +32,8 @@
from ._unit_constants import __all__ as _constants_all
from ._unit_shortcuts import *
from ._unit_shortcuts import __all__ as _std_units_all
from .lax import *
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not import functions in brainunit.lax into brainuni's namespace.

@chaoming0625 chaoming0625 merged commit dd13b46 into main Nov 10, 2024
24 checks passed
@chaoming0625 chaoming0625 deleted the lax-compat branch November 10, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants