fix async http client call-point feature and rest timeout #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhucegep
force-pushed
the
fix_callpoint_and_rest_timeout
branch
from
771824d
to
51b9f2e
Compare
xcaspar
reviewed
Aug 14, 2021
...lade-exec-common/src/main/java/com/alibaba/chaosblade/exec/common/context/GlobalContext.java
Show resolved
Hide resolved
| return beforeEnhancer.doBeforeAdvice(classLoader, className, object, method, methodArguments); | ||
| } | ||
| } | ||
| LOGGER.warn("Can't find enhancer for:{}#{}", className, method.getName()); |
There was a problem hiding this comment.
Will a lot of logs be printed here?
There was a problem hiding this comment.
You're right. I will change the log level to debug.
.../com/alibaba/chaosblade/exec/plugin/http/asynchttpclient/AsyncHttpClientHandlerEnhancer.java
Show resolved
Hide resolved
- fix RestTemplate timeout config - call-point performance optimization Signed-off-by: zhucegep <shizhi.zhu@qunar.com>
zhucegep
force-pushed
the
fix_callpoint_and_rest_timeout
branch
from
51b9f2e
to
87c3333
Compare
xcaspar
reviewed
Aug 16, 2021
|
|
||
| private static final char PACKAGE_SEPARATOR_CHAR = '.'; | ||
|
|
||
| public static String simpleClassName(Class<?> clazz) { |
There was a problem hiding this comment.
Why not use class. getSimpleName() method?
| throw new RuntimeException("contextMap size over limit."); | ||
| } | ||
| } | ||
| Object previous = contextMap.put(key, value); |
There was a problem hiding this comment.
Need to determine whether the value is null.
|
Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it