Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make musl-gcc configurable var to boost local builds #1011

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

spencercjh
Copy link
Contributor

@spencercjh spencercjh commented Mar 11, 2024

Describe what this PR does / why we need it

It would be beneficial to make /usr/local/musl/bin/musl-gcc configurable, as it is often not available on developer's MacBooks, allowing users to adjust it according to their needs.

Does this pull request fix one issue?

NONE

Describe how you did it

Introduce a variable CC for rule nsexecgo in the makefile.

Describe how to verify it

image

Special notes for reviews

…ilitate local builds

Signed-off-by: spencercjh <spencercjh@gmail.com>
@tiny-x tiny-x self-requested a review March 12, 2024 00:40
@tiny-x tiny-x merged commit 7f33b4d into chaosblade-io:master Mar 12, 2024
1 check passed
@spencercjh spencercjh deleted the feat/configurable-cc branch March 12, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants